search

firebase / firebase-tools

The Firebase Command Line Tools
MIT License
4.01k stars 929 forks source link

Fix data connect emulator listen address. #7211

Closed yuchenshi closed 4 months ago

yuchenshi commented 4 months ago

Description

This PR makes the CLI pass --listen=127.0.0.1:9399,[::1]:9399 instead of --http_port and --grpc_port to the Data Connect emulator.

This removes the spearate GRPC port because a single port can now handle both HTTP and GRPC.

It also fixes a bug where the Data Connect emulator listens on all addresses instead of 127.0.0.1 regardless of config in firebase.json.

Scenarios Tested

Ran a local build of a Data Connect emulator with the CLI and verified it responds to both GRPC and HTTP under both 127.0.0.1:9399 and [::1]:9399.

Sample Commands

firebase emulators:start