search

firebase / firebase-tools

The Firebase Command Line Tools
MIT License
3.97k stars 917 forks source link

Improved handling of 'fresh from console' services #7240

Closed joehan closed 1 month ago

joehan commented 1 month ago

Description

During firebase init dataconnect, if there are any services with either no schema or no GQL files n the schema, offer to pull the config from that service.

Also, stop prompting users for connector ID.

Scenarios Tested

I tested: service with no schema:

Screenshot 2024-05-31 at 10 37 56 AM

service with empty schema:

Screenshot 2024-05-31 at 10 13 47 AM

New service (existing flow):

Screenshot 2024-05-31 at 10 38 27 AM
fredzqm commented 1 month ago

Emm, how does auto-merge work?

Is there a way to approve a PR and leave a final nit without triggering it? Critique won't trigger auto-submit when there are unresolved comments.

joehan commented 1 month ago

All good - will clean up the empty case in a follow up PR. TLDR is the autosubmit submits as soon as all the requirements pass. On firebase-tools, those requirements are 1 approving review, no requested changes reviews, and all passing required tests.