search

firebase / firebase-tools

The Firebase Command Line Tools
MIT License
4.01k stars 929 forks source link

Add dataconnect e2e test to CI #7242

Closed joehan closed 3 months ago

joehan commented 4 months ago

Description

Add test:dataconnect-deploy to our CI. Once this is passing consistently, I'll also add it to the required checks and it will block merging if it fails.

I do need to add the target project to our allowlist before this will pass. Somehow, I never got access to that project in the handoff from @bkendall, so looking around for someone who does have access so I can grab the project number

codecov-commenter commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 54.05%. Comparing base (06cb833) to head (45f60c0). Report is 4 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #7242 +/- ## ========================================== - Coverage 54.06% 54.05% -0.01% ========================================== Files 386 386 Lines 26137 26137 Branches 5370 5369 -1 ========================================== - Hits 14131 14129 -2 - Misses 10742 10743 +1 - Partials 1264 1265 +1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.