fix: support deployment of an Angular app using legacy browser builder - Githubissues

firebase / firebase-tools

The Firebase Command Line Tools

MIT License

3.97k stars 916 forks source link

fix: support deployment of an Angular app using legacy browser builder #7264

Closed 9kubczas4 closed 4 weeks ago

9kubczas4 commented 4 weeks ago

Description

This change fixes:

The fix was done in 2 areas of the code:

@angular-devkit/build-angular:browser (app:build:production) is not a recognized builder was thrown because @angular-devkit/build-angular:browser wasn't recognized as build target.
@angular-devkit/build-angular:browser doesn't create browser subfolder in the output path

Scenarios Tested

I've built and deployed to firebase Angular apps (v17) which use:

@angular-devkit/build-angular:browser
@angular-devkit/build-angular:application

Sample Commands

Erkam246 commented 2 weeks ago

@9kubczas4 could you provide us the configuration for @angular-devkit/build-angular:application

Im getting:

Error: @angular-devkit/build-angular:application (app:build:production) is not a recognized builder. Please check your angular.json

with this configuration:

"deploy": {
          "builder": "@angular/fire:deploy",
          "options": {
            "version": 2,
            "browserTarget": "app:build:production"
          }
        }

Update got it working by removing the deploy configuration and changing outputPath to a string