firebase / firebase-tools

The Firebase Command Line Tools
MIT License
3.97k stars 916 forks source link

Make `firebase init dataconnect` not wait for Cloud SQL instances provision #7275

Closed fredzqm closed 3 weeks ago

fredzqm commented 4 weeks ago

Ran through the onboard flow today.

The existing output made me feel compelled to sit there and wait for firebase init to finish. Though customers can totally start coding right away.

Scenarios Tested

firebase init takes over a "fresh from console" service. It spits out a link to monitor Cloud SQL provision instead of a forever long spinner that drives developer away.

Screenshot 2024-06-04 at 11 14 39 PM

Then, rerun firebase init while the Cloud SQL instance is being created.

Screenshot 2024-06-04 at 11 14 10 PM

Then attempt firebase deploy while the Cloud SQL instance is being created.

Screenshot 2024-06-04 at 8 24 10 PM

firebase init when Cloud SQL instance is in a failed state (ran into this while deleting and recreating the instance)

Screenshot 2024-06-04 at 11 09 00 PM
codecov-commenter commented 4 weeks ago

Codecov Report

Attention: Patch coverage is 15.38462% with 11 lines in your changes missing coverage. Please review.

Project coverage is 54.03%. Comparing base (06cb833) to head (67feebb). Report is 25 commits behind head on master.

Files Patch % Lines
src/dataconnect/provisionCloudSql.ts 0.00% 6 Missing :warning:
src/gcp/cloudsql/cloudsqladmin.ts 28.57% 5 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #7275 +/- ## ========================================== - Coverage 54.06% 54.03% -0.04% ========================================== Files 386 386 Lines 26137 26156 +19 Branches 5370 5378 +8 ========================================== + Hits 14131 14133 +2 - Misses 10742 10759 +17 Partials 1264 1264 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.