Closed fredzqm closed 3 weeks ago
Attention: Patch coverage is 15.38462%
with 11 lines
in your changes missing coverage. Please review.
Project coverage is 54.03%. Comparing base (
06cb833
) to head (67feebb
). Report is 25 commits behind head on master.
Files | Patch % | Lines |
---|---|---|
src/dataconnect/provisionCloudSql.ts | 0.00% | 6 Missing :warning: |
src/gcp/cloudsql/cloudsqladmin.ts | 28.57% | 5 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Ran through the onboard flow today.
The existing output made me feel compelled to sit there and wait for
firebase init
to finish. Though customers can totally start coding right away.firebase init dataconnect
not waiting for Cloud SQL instance.state=failed
cloud sql state. Currently, we show those as succeed, but it's actually completely busted and unusable.Scenarios Tested
firebase init
takes over a "fresh from console" service. It spits out a link to monitor Cloud SQL provision instead of a forever long spinner that drives developer away.Then, rerun
firebase init
while the Cloud SQL instance is being created.Then attempt
firebase deploy
while the Cloud SQL instance is being created.firebase init
when Cloud SQL instance is in a failed state (ran into this while deleting and recreating the instance)