firebase / firebase-tools

The Firebase Command Line Tools
MIT License
3.97k stars 915 forks source link

Adding recursive service delete + more #7312

Closed joehan closed 2 weeks ago

joehan commented 2 weeks ago

Description

Round of improvemetns to client.ts

Scenarios Tested

Tested this as part of #7309 - gonna add unit tests for deleteServiceAndChildResources tomorrow as well.

codecov-commenter commented 2 weeks ago

Codecov Report

Attention: Patch coverage is 75.86207% with 7 lines in your changes missing coverage. Please review.

Project coverage is 54.11%. Comparing base (13ffce6) to head (44ee265). Report is 8 commits behind head on master.

Files Patch % Lines
src/dataconnect/client.ts 75.86% 4 Missing and 3 partials :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #7312 +/- ## ========================================== + Coverage 54.02% 54.11% +0.09% ========================================== Files 386 387 +1 Lines 26162 26256 +94 Branches 5380 5392 +12 ========================================== + Hits 14133 14209 +76 - Misses 10765 10780 +15 - Partials 1264 1267 +3 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.