fix: Some emulators would fail to start if there was a whitespace in the path

firebase / firebase-tools

The Firebase Command Line Tools

MIT License

3.97k stars 915 forks source link

fix: Some emulators would fail to start if there was a whitespace in the path #7314

Closed janek515 closed 2 weeks ago

janek515 commented 2 weeks ago

Description

This fixes the issue described in #7313. The binary paths where not surrounded by quotation marks so when a path contained a whitespace it would fail. This affected the pubsub emulator and probably also the data connect emulator though I can't test it as I am not on the close preview.

Scenarios Tested

Tested running the pubsub emulator firebase emulators:start --only pubsub

google-cla[bot] commented 2 weeks ago

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.