search

firebase / firebase-tools

The Firebase Command Line Tools
MIT License
3.97k stars 915 forks source link

Move tests to be colocated with source files. #7318

Closed yuchenshi closed 2 weeks ago

yuchenshi commented 2 weeks ago

Description

e.g. A test file src/tests/foo/bar.spec.js is moved to src/foo/bar.spec.js.

This helps restructuring directories later.

Each commit can be reviewed as a smaller unit.

Scenarios Tested

See GitHub unit and integration test results.

Sample Commands

npm test

joehan commented 2 weeks ago

LGTM since all tests are passing. I know this is a hackweek draft rn, but I'm in favor of the change.

yuchenshi commented 2 weeks ago

Commits all cleaned up and reworded. I've enabled auto-rebase-and-merge too. This now just needs an approval.