search

firebase / firebase-tools

The Firebase Command Line Tools
MIT License
4.01k stars 925 forks source link

App hosting should support pnpm workspace projects #7478

Open debkanchan opened 1 month ago

debkanchan commented 1 month ago

[REQUIRED] Environment info

firebase-tools: 13.13.0

Platform: MacOS

[REQUIRED] Test case

Steps to reproduce should be enough

[REQUIRED] Steps to reproduce

  1. Create a new pnpm workspace with the following pnpm-workspace.yaml 
    packages:
- "apps/*"
- "packages/*"
  2. inside /apps/main init a new nextjs app
  3. inside /packages/random init empty js project
  4. in project root run pnpm i
  5. commit and push to Github
  6. create new app hosting backend, specify app directory to /apps/main

[REQUIRED] Expected behaviour

Deploys the app

[REQUIRED] Actual behaviour

failed to build, lockfile not found

google-oss-bot commented 1 month ago

This issue does not seem to follow the issue template. Make sure you provide all the required information.

aalej commented 1 month ago

Hey @debkanchan, thanks for reaching out and for providing a detailed report. I discussed this with our engineering team. Currently, pnpm is supported, however pnpm workspaces is not. For now, I’ll mark this as a feature request.

benyap commented 4 weeks ago

Hi @aalej, just thought I'd chip in and mention a similar discussion that was started here: https://github.com/firebase/firebase-tools/discussions/7206#discussioncomment-10348334

Looking forward to see official support for pnpm workspaces at some point in the future.