search

firebase / firebase-unity-sdk

The Firebase SDK for Unity
http://firebase.google.com
Apache License 2.0
226 stars 37 forks source link

[FR] Make Firebase UPM packages available on Github #460

Open SpungeLuke opened 2 years ago

SpungeLuke commented 2 years ago

[READ] Guidelines

When filing a feature request please make sure the issue title starts with "[FR]".

A good feature request ideally

Once you've read this section, please delete it and fill out the rest of the template.

Feature proposal

Hi there! It would be nice if we could have the built SDKs hosted so they can be automatically updated with the Unity Package Manager, then rather than manually updating Tarballs it'd be a simple one click update. OpenUPM has an unofficial package but I'd rather not rely on a 3rd party for something as mission critical as Firebase so an officially hosted package would be great! Thank you!

google-oss-bot commented 2 years ago

I couldn't figure out how to label this issue, so I've labeled it for a human to triage. Hang tight.

chkuang-g commented 2 years ago

@SpungeLuke

I heard you and you are wise to be cautious about the package hosted on OpenUPM, which is not published by us. (and we probably cannot publish there either.)

Let me bring this up to the team and see how we can do with this.

If anyone are interested in this feature, please upvote to let us know.

Shawn

DaveMariner commented 2 years ago

It's my understanding that the UPM repo was taken down due to Unity licensing changes. What we ended up doing was a self-hosted Verdaccio server and semi-automating the update with some simple hacked-together python(?) scripts.

What would be REALLY useful would be an SDK-announce mailing list that I could subscribe to and get notified of a new SDK release so I could kick our update script.

That and/or a JSON endpoint with current version, release notes, URI of the gzip. Then I could set up a cron job to monitor this, detect any changes, update our repo and notify internally.

Joakim432710 commented 1 year ago

I agree, however from my understanding of the matter we should be able to add UPM support to the github repo itself by having the built dependencies in a subfolder under the tagged releases, something like https://github.com/firebase/firebase-unity-sdk#v10.1.1?path=Unity/Firebase.App As long as the tagged commits have the tgz's in extracted format in whatever path we specify Unity will recognize the package.json and download it directly from github. I'm not sure on the legal here but it seems like a solid alternative

I agree with Dave, a mailing list or even some place we could poll for would be good

StephenHodgson commented 1 year ago

+1000 on this FR

I do like the idea of using the GIT url, but a self hosted Verdaccio server would def be the way to go imho. I've had to support this internally for different companies with a private registry and it went pretty smoothly. Should be straight forward.

Also, I think the OpenUPM firebase package is REST only and doesn't support everything out of the box, but it did help our team with issues around using Firebase on Oculus Quest platform since it didn't have google play store.

Thaina commented 1 year ago

I wish I could also import this package as raw source code

At least for the C# parts. The main dll can still be compiled and only reference as dll. But C# code that was the API should be raw code in git package. Which means we could import them and debug or pull and modified them easily when we need

And it might be possible to extend support for other platform such as webgl easier. I have planned to pull this repo and bring only C# parts to wrap it over jslib. But if you would kindly make this repo become source of UPM git (which actually should be from the start) then this would simplified my plan

Thaina commented 1 year ago

@huangchaoqun It was not solve the issue of trust and officiality maintaining

StephenHodgson commented 8 months ago

I made a mirror/archive of all of the available packages from https://developers.google.com/unity/archive

Includes all of the old versions and automatically updates as new ones are published. https://github.com/orgs/RageAgainstThePixel/repositories?q=com.google.firebase

StephenHodgson commented 8 months ago

Also, context on why it isn't available via scoped registry anymore 😭

Thaina commented 6 months ago

Google ads for unity now provided in openupm. Please add all firebase in there too

https://github.com/googleads/googleads-mobile-unity/issues/1416#issuecomment-2033094318

Thaina commented 4 months ago

Not just OpenUPM. Most Google package now can be add from github directly. Which is very convenience

https://github.com/googlesamples/unity-jar-resolver/tree/master/upm https://github.com/google/play-unity-plugins/tree/master/GooglePlayPlugins

Only firebase are stuck in my repo as tgz, which is annoying