firebase / firebaseui-web

FirebaseUI is an open-source JavaScript library for Web that provides simple, customizable UI bindings on top of Firebase SDKs to eliminate boilerplate code and promote best practices.
https://firebase.google.com/
Apache License 2.0
4.59k stars 1.06k forks source link

Incorrect error message when password requirements not met #1054

Open pb-jeff-oneill opened 11 months ago

pb-jeff-oneill commented 11 months ago

I'm using Firebase Auth with Google Identity Platform and I recently set stricter password requirements than the defaults.

When a user goes through the password reset process and enters a password that doesn't meet the requirements, they see this message:

Try resetting your password again Your request to reset your password has expired or the link has already been used

But this error message is incorrect.

The actual HTTP response is this:

{
  "error": {
    "code": 400,
    "message": "PASSWORD_DOES_NOT_MEET_REQUIREMENTS : Missing password requirements: [Password must contain at least 8 characters, Password must contain a lower case character, Password must contain an upper case character, Password must contain a non-alphanumeric character]",
    "errors": [
      {
        "message": "PASSWORD_DOES_NOT_MEET_REQUIREMENTS : Missing password requirements: [Password must contain at least 8 characters, Password must contain a lower case character, Password must contain an upper case character, Password must contain a non-alphanumeric character]",
        "domain": "global",
        "reason": "invalid"
      }
    ]
  }
}

It looks like firebaseui-web is ignoring the content of the HTTP response and using the "expired" message for all 400 errors.

Could you please update to provide the correct error message? This is very confusing for end users.

jhuleatt commented 11 months ago

Hi @pb-jeff-oneill, good news - this was fixed in https://github.com/firebase/firebaseui-web/pull/1047. We just need to run a release to get the error message fixes out. Expect a version 6.1.1 soon that has this fix.

pb-jeff-oneill commented 10 months ago

Thank you. I'm looking forward to the 6.1.1 release!

pb-jeff-oneill commented 8 months ago

Can you please deploy the 6.1.1 release? It has been months!