search

firebase / firebaseui-web

FirebaseUI is an open-source JavaScript library for Web that provides simple, customizable UI bindings on top of Firebase SDKs to eliminate boilerplate code and promote best practices.
https://firebase.google.com/
Apache License 2.0
4.57k stars 1.05k forks source link

Disabling 'accountchooser' doesn't prevent storing `firebaseui::rememberedAccounts` in local storage #551

Open mahsa2 opened 5 years ago

mahsa2 commented 5 years ago

I have disabled 'accountchooser' using credentialHelper: firebaseui.auth.CredentialHelper.NONE. But, after each google login, firebaseui::rememberedAccounts is still created in local storage. If the data is only used by the accountchooser, is there any way to stop this storage? If not, could you please consider implementing it?

Thank you in advance.

francos commented 4 years ago

@mahsa2 did you find a workaround for this? I'm having the same issue, I don't want to use the account chooser but it keeps appearing even though I disabled it.

mahsa2 commented 4 years ago

@francos To disable the "account chooser" I set credentialHelper: firebaseui.auth.CredentialHelper.NONE. Regarding the local storage it creates (firebaseui::rememberedAccounts), you might want to manually remove it in the callbacks: signInSuccessWithAuthResult and signInFailure.

francos commented 4 years ago

Thanks for the info @mahsa2! 👍

rpanaro commented 4 years ago

I'm also wondering why it still seems to be doing so much stuff after being disabled..

It keeps logging:

Read saved accounts from storage: []
Send message: {"jsonrpc":"2.0","rpcToken":"1371795982","build":20160119,"method":"clientReadyNotification"}
Get accountchooser browser config: {}
Send message: {"jsonrpc":"2.0","rpcToken":"1371795982","build":20160119,"method":"emptyResponseNotification"}
Received message: {"jsonrpc":"2.0","rpcToken":"1371795982","build":20160119,"method":"emptyResponseNotification"} 
from https://www.accountchooser.com

from accountchooser.com/static/57/ac-iframe.js and gstatic.com/accountchooser/client.js

Considering how accountchooser announced gradual shutdown in July 2019, why does FirebaseUI still have it integrated?