search

firebase / firebaseui-web

FirebaseUI is an open-source JavaScript library for Web that provides simple, customizable UI bindings on top of Firebase SDKs to eliminate boilerplate code and promote best practices.
https://firebase.google.com/
Apache License 2.0
4.58k stars 1.06k forks source link

Publish localized package to NPM #902

Open wonsuc opened 2 years ago

wonsuc commented 2 years ago

Not like Firebase Web SDK version 8 or earlier, version 9 (which is recently released) uses a JavaScript Module format by default.

For this reason, the FirebaseUI Web library also should provide localized versions on NPM.

It's pretty difficult to clone the repository and compile and import localized version manually. (in my case, I get compile error)

Actually, I thought localization with this library is pretty easy (because "easy" and "convenient" are the reason why most people choose this library), something like this.

import * as firebaseui from 'firebaseui';
import * from 'firebaseui-ko'; // something like additional one line importing

However, I figured out it won't work like this easily for localization.

I saw the comment that you guys planning this in 2018 and I think this is the right time to commit to the plan.

Thank you for the support.

bonatoc commented 2 years ago

While you're at it, everytime we upgrade or add a node module, all the translation files in ./node_modules/firebaseui get erased, resulting in a major bug (couldn't find node module 'npm_[language]').

There has to be a better way to upgrade hte modules without rewriting the whole firebaseui folder.

landsman commented 2 years ago

Probably related with #662