search

firebase / flutterfire

🔥 A collection of Firebase plugins for Flutter apps.
https://firebase.google.com/docs/flutter/setup
BSD 3-Clause "New" or "Revised" License
8.6k stars 3.95k forks source link

🐛 [firebase_dynamic_links] onLink listener not signaling faulty dynamic link data URI #10323

Closed toebgen closed 1 year ago

toebgen commented 1 year ago

Bug report

We have set up Firebase Authentication as well as Dynamic Links as described in the respective tutorials (here and here). Logins (Social, Email Link) as well as deep links into the app work fine.

However, we encountered an issue as described for firebase-js already: https://github.com/firebase/firebase-js-sdk/issues/5054. In this case, a faulty URL is given as dynamic link data. For example https://link.[xyz].app/?link=https://xyz.firebaseapp.com/__/[...] becomes https:/link.[xyz].app/?link=https://xyz.firebaseapp.com/__/[...] (note the missing /).

The listener for the latest dynamic link events FirebaseDynamicLinks.instance.onLink.listen() does not emit anything in this case, the faulty URL seems to be silently failing the internal parsing.

Expected behavior

It would be really helpful, if one would get some information about this, instead. FirebaseDynamicLinks.instance.onLink.listen() should emit some information about a faulty URL being received, maybe even an error.

Flutter doctor

Run flutter doctor and paste the output below:

Click To Expand ``` Doctor summary (to see all details, run flutter doctor -v): [✓] Flutter (Channel stable, 3.3.10, on macOS 12.6.2 21G320 darwin-arm, locale en-DE) [✓] Android toolchain - develop for Android devices (Android SDK version 33.0.0-rc1) [✓] Xcode - develop for iOS and macOS (Xcode 14.2) [✓] Chrome - develop for the web [✓] Android Studio (version 2021.1) [✓] VS Code (version 1.74.3) [✓] Connected device (2 available) [✓] HTTP Host Availability • No issues found! ```
darshankawar commented 1 year ago

Thanks for the report. Treating this as an enhancement for the plugin to detect and emit some information about a faulty URL being received, maybe even an error.

russellwheatley commented 1 year ago

Hey @toebgen, do you mind providing steps to reproduce this issue and I can take a look?

google-oss-bot commented 1 year ago

Hey @toebgen. We need more information to resolve this issue but there hasn't been an update in 7 weekdays. I'm marking the issue as stale and if there are no new updates in the next 7 days I will close it automatically.

If you have more information that will help us get to the bottom of this, just add a comment!

google-oss-bot commented 1 year ago

Since there haven't been any recent updates here, I am going to close this issue.

@toebgen if you're still experiencing this problem and want to continue the discussion just leave a comment here and we are happy to re-open this.