search

firebase / flutterfire

🔥 A collection of Firebase plugins for Flutter apps.
https://firebase.google.com/docs/flutter/setup
BSD 3-Clause "New" or "Revised" License
8.72k stars 3.97k forks source link

🐛 [firebase_dynamic_links] GoRouter redirect does not work on iOS #10346

Closed bstolinski closed 10 months ago

bstolinski commented 1 year ago

Bug report

Describe the bug Changes in version 5.0.9 https://github.com/firebase/flutterfire/pull/10100 have broken GoRouter's deep link capture on iOS. This only applies to Firebase Dynamic Links, other custom deep links works correctly. It opens the app, but that's it. In version 5.0.8 everything worked fine. In version 5.0.9+ it only works on Android. I know firebase_dynamic_links has its own methods for this but maybe it would be possible to look at and fix this. This may be related to: https://github.com/firebase/flutterfire/issues/10340 https://github.com/firebase/flutterfire/issues/10336 https://github.com/firebase/flutterfire/issues/10262

Steps to reproduce

Steps to reproduce the behavior:

  1. Implement simple GoRouter app with redirect
  2. Click firebase dynamic link
  3. App will open but not trigger GoRouter redirect

Flutter doctor

Run flutter doctor and paste the output below:

Click To Expand ``` Doctor summary (to see all details, run flutter doctor -v): [✓] Flutter (Channel stable, 3.7.0, on macOS 13.1 22C65 darwin-x64, locale en-GB) [✓] Android toolchain - develop for Android devices (Android SDK version 32.1.0-rc1) [✓] Xcode - develop for iOS and macOS (Xcode 14.2) [✓] Chrome - develop for the web [✓] Android Studio (version 2022.1) [✓] Connected device (3 available) [✓] HTTP Host Availability • No issues found! ```

Flutter dependencies

Run flutter pub deps -- --style=compact and paste the output below:

Click To Expand ``` Dart SDK 2.19.0 Flutter SDK 3.7.0 dependencies: - android_intent_plus 3.1.5 [flutter platform meta] - archive 3.3.6 [crypto path pointycastle] - async 2.10.0 [collection meta] - auto_size_text 3.0.0 [flutter] - better_player 0.0.83 [flutter cupertino_icons wakelock meta flutter_widget_from_html_core visibility_detector path_provider collection xml] - cached_network_image 3.2.3 [flutter flutter_cache_manager octo_image cached_network_image_platform_interface cached_network_image_web] - centrifuge 0.9.3 [fixnum meta protobuf web_socket_channel] - characters 1.2.1 - collection 1.17.1 - connectivity_plus 3.0.2 [flutter flutter_web_plugins connectivity_plus_platform_interface js meta nm] - crypto 3.0.2 [typed_data] - device_info_plus 8.0.0 [device_info_plus_platform_interface ffi file flutter flutter_web_plugins meta win32] - dio 4.0.6 [http_parser path] - dio_http2_adapter 2.0.0 [http2 dio] - drift 2.5.0 [async convert collection js meta stream_channel sqlite3] - drift_local_storage_inspector 0.5.0 [drift flutter storage_inspector] - equatable 2.0.5 [collection meta] - extended_text_field 10.2.0 [extended_text_library flutter] - file 6.1.4 [meta path] - file_local_storage_inspector 0.3.1 [flutter path storage_inspector uuid] - file_picker 5.2.5 [flutter flutter_web_plugins flutter_plugin_android_lifecycle plugin_platform_interface ffi path win32] - firebase_analytics 10.1.0 [firebase_analytics_platform_interface firebase_analytics_web firebase_core firebase_core_platform_interface flutter] - firebase_auth 4.2.5 [firebase_auth_platform_interface firebase_auth_web firebase_core firebase_core_platform_interface flutter meta] - firebase_core 2.4.1 [firebase_core_platform_interface firebase_core_web flutter meta] - firebase_dynamic_links 5.0.9 [firebase_core firebase_core_platform_interface firebase_dynamic_links_platform_interface flutter meta plugin_platform_interface] - firebase_messaging 14.2.1 [firebase_core firebase_core_platform_interface firebase_messaging_platform_interface firebase_messaging_web flutter meta] - flutter 0.0.0 [characters collection js material_color_utilities meta vector_math sky_engine] - flutter_app_badger 1.5.0 [flutter] - flutter_dotenv 5.0.2 [flutter] - flutter_image_compress 1.1.3 [flutter] - flutter_local_notifications 13.0.0 [clock flutter flutter_local_notifications_linux flutter_local_notifications_platform_interface timezone] - flutter_localizations 0.0.0 [flutter intl characters clock collection js material_color_utilities meta path vector_math] - flutter_sticky_header 0.6.5 [flutter value_layout_builder] - flutter_svg 1.1.6 [flutter meta path_drawing vector_math xml] - flutter_swipe_action_cell 3.1.0 [flutter] - flutter_timezone 1.0.4 [flutter_web_plugins flutter js] - flutter_video_info 1.3.1 [flutter path] - get_it 7.2.0 [async collection] - go_router 5.3.0 [collection flutter flutter_web_plugins logging meta] - google_fonts 4.0.1 [flutter http path_provider crypto] - google_sign_in 5.4.4 [flutter google_sign_in_android google_sign_in_ios google_sign_in_platform_interface google_sign_in_web] - http2 2.0.1 - http_parser 4.0.2 [collection source_span string_scanner typed_data] - image_cropper 3.0.1 [flutter image_cropper_platform_interface image_cropper_for_web] - image_picker 0.8.6+1 [flutter image_picker_android image_picker_for_web image_picker_ios image_picker_platform_interface] - infinite_scroll_pagination 3.2.0 [flutter sliver_tools] - injectable 2.1.0 [get_it] - intl 0.18.0 [clock meta path] - json_annotation 4.8.0 [meta] - logging 1.1.1 - mime 1.0.4 - mutex 3.0.1 - package_info_plus 3.0.2 [ffi flutter flutter_web_plugins http meta path package_info_plus_platform_interface win32] - path 1.8.2 - path_provider 2.0.12 [flutter path_provider_android path_provider_foundation path_provider_linux path_provider_platform_interface path_provider_windows] - permission_handler 10.2.0 [flutter meta permission_handler_android permission_handler_apple permission_handler_windows permission_handler_platform_interface] - preferences_local_storage_inspector 0.3.1 [flutter shared_preferences storage_inspector tuple uuid] - provider 6.0.5 [collection flutter nested] - purchases_flutter 4.8.0 [flutter freezed_annotation json_annotation] - rxdart 0.27.7 - screenshot 1.3.0 [flutter] - scrollable_clean_calendar 1.4.0 [flutter intl scrollable_positioned_list] - scrollable_positioned_list 0.3.5 [flutter collection] - sentry_dio 6.19.0 [dio sentry] - sentry_flutter 6.19.0 [flutter flutter_web_plugins sentry package_info_plus meta] - sentry_logging 6.19.0 [logging sentry] - share_plus 6.3.0 [cross_file meta mime flutter flutter_web_plugins share_plus_platform_interface file url_launcher_web url_launcher_windows url_launcher_linux url_launcher_platform_interface ffi win32] - shared_preferences 2.0.17 [flutter shared_preferences_android shared_preferences_foundation shared_preferences_linux shared_preferences_platform_interface shared_preferences_web shared_preferences_windows] - shimmer 2.0.0 [flutter] - sign_in_with_apple 4.3.0 [flutter meta sign_in_with_apple_platform_interface sign_in_with_apple_web] - sliver_tools 0.2.8 [flutter] - sqlite3_flutter_libs 0.5.12 [flutter] - storage_inspector 0.3.0 [async dart_service_announcement flutter synchronized tuple uri uuid] - stream_chat_flutter_core 5.3.0 [collection connectivity_plus flutter freezed_annotation meta rxdart stream_chat] - stream_transform 2.1.0 - url_launcher 6.1.8 [flutter url_launcher_android url_launcher_ios url_launcher_linux url_launcher_macos url_launcher_platform_interface url_launcher_web url_launcher_windows] - uuid 3.0.7 [crypto] - video_thumbnail 0.5.3 [flutter] - visibility_detector 0.3.3 [flutter] - web_socket_channel 2.3.0 [async crypto stream_channel] dev dependencies: - build_runner 2.3.3 [args async analyzer build build_config build_daemon build_resolvers build_runner_core code_builder collection crypto dart_style frontend_server_client glob graphs http_multi_server io js logging meta mime package_config path pool pub_semver pubspec_parse shelf shelf_web_socket stack_trace stream_transform timing watcher web_socket_channel yaml] - dart_code_metrics 5.5.1 [analyzer analyzer_plugin ansicolor args collection crypto dart_code_metrics_presets file glob html meta path platform pub_updater source_span xml yaml] - drift_dev 2.5.0+1 [charcode collection recase meta path json_annotation stream_transform args logging cli_util yaml io drift sqlite3 sqlparser analyzer analyzer_plugin source_span package_config pub_semver build build_resolvers build_config dart_style source_gen string_scanner] - flutter_lints 2.0.1 [lints] - flutter_test 0.0.0 [flutter test_api path fake_async clock stack_trace vector_math async boolean_selector characters collection js matcher material_color_utilities meta source_span stream_channel string_scanner term_glyph] - injectable_generator 2.1.3 [build source_gen path glob analyzer code_builder dart_style injectable collection recase] - json_serializable 6.6.0 [analyzer async build build_config collection json_annotation meta path pub_semver pubspec_parse source_gen source_helper] - mocktail 0.3.0 [collection matcher test] - sentry_dart_plugin 1.0.0-beta.5 [yaml injector ansicolor system_info2 file http crypto convert process] dependency overrides: - collection 1.17.1 - intl 0.18.0 [clock meta path] transitive dependencies: - _fe_analyzer_shared 52.0.0 [meta] - _flutterfire_internals 1.0.12 [collection firebase_core firebase_core_platform_interface flutter meta] - analyzer 5.4.0 [_fe_analyzer_shared collection convert crypto glob meta package_config path pub_semver source_span watcher yaml] - analyzer_plugin 0.11.2 [analyzer collection dart_style pub_semver yaml] - ansicolor 2.0.1 - args 2.3.2 - asn1lib 1.4.0 - boolean_selector 2.1.1 [source_span string_scanner] - build 2.3.1 [analyzer async convert crypto glob logging meta path] - build_config 1.1.1 [checked_yaml json_annotation path pubspec_parse yaml] - build_daemon 3.1.0 [built_collection built_value http_multi_server logging path pool shelf shelf_web_socket stream_transform watcher web_socket_channel] - build_resolvers 2.1.0 [analyzer async build crypto graphs logging path package_config pool pub_semver stream_transform yaml] - build_runner_core 7.2.7 [async build build_config build_resolvers collection convert crypto glob graphs json_annotation logging meta path package_config pool timing watcher yaml] - built_collection 5.1.1 - built_value 8.4.3 [built_collection collection fixnum meta] - cached_network_image_platform_interface 2.0.0 [flutter flutter_cache_manager] - cached_network_image_web 1.0.2 [flutter flutter_cache_manager cached_network_image_platform_interface] - charcode 1.3.1 - checked_yaml 2.0.2 [json_annotation source_span yaml] - cli_util 0.3.5 [meta path] - clock 1.1.1 - code_builder 4.4.0 [built_collection built_value collection matcher meta] - connectivity_plus_platform_interface 1.2.3 [flutter meta plugin_platform_interface] - convert 3.1.1 [typed_data] - coverage 1.6.2 [args logging package_config path source_maps stack_trace vm_service] - cross_file 0.3.3+2 [js meta] - crypto_keys 0.3.0+1 [pointycastle meta collection quiver] - csslib 0.17.2 [source_span] - cupertino_icons 1.0.5 - dart_code_metrics_presets 1.1.0 - dart_service_announcement 1.2.3 [logging synchronized] - dart_style 2.2.4 [analyzer args path pub_semver source_span] - dbus 0.7.8 [args ffi meta xml] - device_info_plus_platform_interface 7.0.0 [flutter meta plugin_platform_interface] - extended_text_library 9.1.1 [flutter] - fake_async 1.3.1 [clock collection] - ffi 2.0.1 - file_utils 1.0.1 [globbing path] - firebase_analytics_platform_interface 3.3.17 [_flutterfire_internals firebase_core flutter meta plugin_platform_interface] - firebase_analytics_web 0.5.1+8 [_flutterfire_internals firebase_analytics_platform_interface firebase_core firebase_core_web flutter flutter_web_plugins js] - firebase_auth_platform_interface 6.11.6 [_flutterfire_internals collection firebase_core flutter meta plugin_platform_interface] - firebase_auth_web 5.2.4 [firebase_auth_platform_interface firebase_core firebase_core_web flutter flutter_web_plugins http_parser intl js meta] - firebase_core_platform_interface 4.5.2 [collection flutter flutter_test meta plugin_platform_interface] - firebase_core_web 2.1.0 [firebase_core_platform_interface flutter flutter_web_plugins js meta] - firebase_dynamic_links_platform_interface 0.2.3+26 [_flutterfire_internals firebase_core flutter meta plugin_platform_interface] - firebase_messaging_platform_interface 4.2.10 [_flutterfire_internals firebase_core flutter meta plugin_platform_interface] - firebase_messaging_web 3.2.11 [_flutterfire_internals firebase_core firebase_core_web firebase_messaging_platform_interface flutter flutter_web_plugins js meta] - fixnum 1.0.1 - flutter_blurhash 0.7.0 [flutter] - flutter_cache_manager 3.3.0 [clock collection file flutter http path path_provider pedantic rxdart sqflite uuid] - flutter_local_notifications_linux 3.0.0 [dbus ffi flutter flutter_local_notifications_platform_interface path xdg_directories] - flutter_local_notifications_platform_interface 6.0.0 [flutter plugin_platform_interface] - flutter_plugin_android_lifecycle 2.0.7 [flutter] - flutter_web_plugins 0.0.0 [flutter js characters collection material_color_utilities meta vector_math] - flutter_widget_from_html_core 0.8.5+3 [csslib flutter fwfh_text_style html] - freezed_annotation 2.2.0 [collection json_annotation meta] - frontend_server_client 3.2.0 [async path] - fwfh_text_style 2.22.08+1 [flutter] - glob 2.1.1 [async collection file path string_scanner] - globbing 1.0.0 [path] - google_sign_in_android 6.1.5 [flutter google_sign_in_platform_interface] - google_sign_in_ios 5.5.1 [flutter google_sign_in_platform_interface] - google_sign_in_platform_interface 2.3.0 [flutter plugin_platform_interface quiver] - google_sign_in_web 0.10.2+1 [flutter flutter_web_plugins google_sign_in_platform_interface js] - graphs 2.2.0 [collection] - html 0.15.1 [csslib source_span] - http 0.13.5 [async http_parser meta path] - http_multi_server 3.2.1 [async] - image_cropper_for_web 1.0.3 [flutter flutter_web_plugins image_cropper_platform_interface js] - image_cropper_platform_interface 3.0.3 [flutter plugin_platform_interface http] - image_picker_android 0.8.5+5 [flutter flutter_plugin_android_lifecycle image_picker_platform_interface] - image_picker_for_web 2.1.10 [flutter flutter_web_plugins image_picker_platform_interface] - image_picker_ios 0.8.6+6 [flutter image_picker_platform_interface] - image_picker_platform_interface 2.6.2 [cross_file flutter http plugin_platform_interface] - injector 2.0.0 - io 1.0.4 [meta path string_scanner] - jose 0.3.3 [crypto_keys meta typed_data x509 http http_parser asn1lib collection] - js 0.6.5 [meta] - lints 2.0.1 - matcher 0.12.13 [meta stack_trace] - material_color_utilities 0.2.0 - meta 1.8.0 - nested 1.0.0 [flutter] - nm 0.5.0 [dbus] - node_preamble 2.0.1 - octo_image 1.0.2 [flutter flutter_blurhash] - package_config 2.1.0 [path] - package_info_plus_platform_interface 2.0.1 [flutter meta plugin_platform_interface] - path_drawing 1.0.1 [vector_math meta path_parsing flutter] - path_parsing 1.0.1 [vector_math meta] - path_provider_android 2.0.22 [flutter path_provider_platform_interface] - path_provider_foundation 2.1.1 [flutter path_provider_platform_interface] - path_provider_linux 2.1.7 [ffi flutter path path_provider_platform_interface xdg_directories] - path_provider_platform_interface 2.0.5 [flutter platform plugin_platform_interface] - path_provider_windows 2.1.3 [ffi flutter path path_provider_platform_interface win32] - pedantic 1.11.1 - permission_handler_android 10.2.0 [flutter permission_handler_platform_interface] - permission_handler_apple 9.0.7 [flutter permission_handler_platform_interface] - permission_handler_platform_interface 3.9.0 [flutter meta plugin_platform_interface] - permission_handler_windows 0.1.2 [flutter permission_handler_platform_interface] - petitparser 5.1.0 [meta] - platform 3.1.0 - plugin_platform_interface 2.1.3 [meta] - pointycastle 3.6.2 [collection convert js] - pool 1.5.1 [async stack_trace] - process 4.2.4 [file path platform] - protobuf 2.1.0 [fixnum collection meta] - pub_semver 2.1.3 [collection meta] - pub_updater 0.2.4 [http json_annotation process] - pubspec_parse 1.2.1 [checked_yaml collection json_annotation pub_semver yaml] - quiver 3.2.1 [matcher] - rate_limiter 1.0.0 - recase 4.1.0 - sentry 6.19.0 [http meta stack_trace uuid intl] - share_plus_platform_interface 3.2.0 [cross_file flutter meta mime plugin_platform_interface path_provider uuid] - shared_preferences_android 2.0.15 [flutter shared_preferences_platform_interface] - shared_preferences_foundation 2.1.2 [flutter shared_preferences_platform_interface] - shared_preferences_linux 2.1.3 [file flutter path path_provider_linux path_provider_platform_interface shared_preferences_platform_interface] - shared_preferences_platform_interface 2.1.0 [flutter plugin_platform_interface] - shared_preferences_web 2.0.4 [flutter flutter_web_plugins shared_preferences_platform_interface] - shared_preferences_windows 2.1.3 [file flutter path path_provider_platform_interface path_provider_windows shared_preferences_platform_interface] - shelf 1.4.0 [async collection http_parser path stack_trace stream_channel] - shelf_packages_handler 3.0.1 [path shelf shelf_static] - shelf_static 1.1.1 [convert http_parser mime path shelf] - shelf_web_socket 1.0.3 [shelf stream_channel web_socket_channel] - sign_in_with_apple_platform_interface 1.0.0 [flutter plugin_platform_interface meta] - sign_in_with_apple_web 1.0.1 [flutter flutter_web_plugins sign_in_with_apple_platform_interface js] - sky_engine 0.0.99 - source_gen 1.2.6 [analyzer async build dart_style glob meta path source_span yaml] - source_helper 1.3.3 [analyzer collection source_gen] - source_map_stack_trace 2.1.1 [path source_maps stack_trace] - source_maps 0.10.11 [source_span] - source_span 1.9.1 [collection path term_glyph] - sqflite 2.2.3 [flutter sqflite_common path] - sqflite_common 2.4.1 [synchronized path meta] - sqlite3 1.9.1 [collection ffi js meta path] - sqlparser 0.27.0 [meta collection source_span charcode] - stack_trace 1.11.0 [path] - stream_channel 2.1.1 [async] - stream_chat 5.3.0 [async collection dio equatable freezed_annotation http_parser jose json_annotation logging meta mime rate_limiter rxdart uuid web_socket_channel] - string_scanner 1.2.0 [source_span] - synchronized 3.0.1 - system_info2 3.0.1 [file_utils path] - term_glyph 1.2.1 - test 1.22.0 [analyzer async boolean_selector collection coverage http_multi_server io js node_preamble package_config path pool shelf shelf_packages_handler shelf_static shelf_web_socket source_span stack_trace stream_channel typed_data web_socket_channel webkit_inspection_protocol yaml test_api test_core] - test_api 0.4.16 [async boolean_selector collection meta source_span stack_trace stream_channel string_scanner term_glyph matcher] - test_core 0.4.20 [analyzer async args boolean_selector collection coverage frontend_server_client glob io meta package_config path pool source_map_stack_trace source_maps source_span stack_trace stream_channel vm_service yaml matcher test_api] - timezone 0.9.1 [path] - timing 1.0.1 [json_annotation] - tuple 2.0.1 - typed_data 1.3.1 [collection] - uri 1.0.0 [matcher quiver] - url_launcher_android 6.0.23 [flutter url_launcher_platform_interface] - url_launcher_ios 6.0.18 [flutter url_launcher_platform_interface] - url_launcher_linux 3.0.2 [flutter url_launcher_platform_interface] - url_launcher_macos 3.0.2 [flutter url_launcher_platform_interface] - url_launcher_platform_interface 2.1.1 [flutter plugin_platform_interface] - url_launcher_web 2.0.14 [flutter flutter_web_plugins url_launcher_platform_interface] - url_launcher_windows 3.0.3 [flutter url_launcher_platform_interface] - value_layout_builder 0.3.1 [flutter] - vector_math 2.1.4 - vm_service 9.4.0 - wakelock 0.6.2 [flutter meta wakelock_macos wakelock_platform_interface wakelock_web wakelock_windows] - wakelock_macos 0.4.0 [flutter flutter_web_plugins wakelock_platform_interface] - wakelock_platform_interface 0.3.0 [flutter meta] - wakelock_web 0.4.0 [flutter flutter_web_plugins js wakelock_platform_interface] - wakelock_windows 0.2.1 [flutter wakelock_platform_interface win32] - watcher 1.0.2 [async path] - webkit_inspection_protocol 1.2.0 [logging] - win32 3.1.3 [ffi] - x509 0.2.3 [asn1lib quiver crypto_keys] - xdg_directories 0.2.0+3 [meta path process] - xml 6.2.2 [collection meta petitparser] - yaml 3.1.1 [collection source_span string_scanner] ```
darshankawar commented 1 year ago

Thanks for the report @bstolinski Can you please go through this issue and underlying comment and check if it resembles the use case you are describing ?

bstolinski commented 1 year ago

Hi @darshankawar, if I understand the author of this correctly then he wants the opposite effect to mine - version 3.0.9+ should solve his problem on iOS (not sure about Android).

Back to my problem, in my app I don't use the firebase_dynamic_links onLink and getInitialLink methods at all. Up to version 3.0.8 inclusive, I was handling all dynamic links exclusively using go_router. My implementation stopped working due to the changes made here (I checked it several times), however in version 3.0.9+ (I didn't check in the others) onLink and getInitialLink work fine.

So my question is whether it is possible to add an option whether dynamic links are to be handled only by firebase_dynamic_links (current 3.0.9+ behaviour) or by other libraries as well.

darshankawar commented 1 year ago

So my question is whether it is possible to add an option whether dynamic links are to be handled only by firebase_dynamic_links (current 3.0.9+ behaviour) or by other libraries as well.

I am trying to wrap my head around this, but still not completely sure about it. I think other libraries too should handle the dynamic links. See this issue and check if it helps in your case.

bstolinski commented 1 year ago

I am trying to wrap my head around this, but still not completely sure about it. I think other libraries too should handle the dynamic links. See https://github.com/flutter/flutter/issues/103659 issue and check if it helps in your case.

It was working before this change (one line of code) so I don't understand why you are sending a link to an issue that is not related to this at all.

Is my problem unclear to you? Should I try to describe it better?

google-oss-bot commented 1 year ago

Hey @bstolinski. We need more information to resolve this issue but there hasn't been an update in 7 weekdays. I'm marking the issue as stale and if there are no new updates in the next 7 days I will close it automatically.

If you have more information that will help us get to the bottom of this, just add a comment!

TomBeckett commented 1 year ago

Bump. I dont think this is blocked waiting for customer response @darshankawar

google-oss-bot commented 1 year ago

Hey @bstolinski. We need more information to resolve this issue but there hasn't been an update in 7 weekdays. I'm marking the issue as stale and if there are no new updates in the next 7 days I will close it automatically.

If you have more information that will help us get to the bottom of this, just add a comment!

TomBeckett commented 1 year ago

Still an issue.

google-oss-bot commented 1 year ago

Hey @bstolinski. We need more information to resolve this issue but there hasn't been an update in 7 weekdays. I'm marking the issue as stale and if there are no new updates in the next 7 days I will close it automatically.

If you have more information that will help us get to the bottom of this, just add a comment!

sirwes commented 1 year ago

I get the same issue. When debugging, the goRouter prints out "going to /?link= ..." the entire dynamic link, which indicates to me that the dynamic links library is not parsing the dynamic link correctly. It works just fine on Android.

Although I can't seem to get it working on any 5.* version.

I do notice that if I click the link and it brings me to the "Open link in app?" page and I hit open I get this non-functional behavior, but if I long hold the open button to open in browser then it brings me to a "Failed to resolve uri domain" and lists the whitelisted URL with the attached route. Sometimes a smart banner "Open in app" appears and when I hit that it works as expected

For example, in my situation, my whitelisted domain is link.turfsports.co (regex preview is ^https{0,1}:\/\/link.turfsports.co([\/#\?].*){0,1}$) and the failed Uri domain prefix is https://link.turfsports.co/mypage/myvar

google-oss-bot commented 1 year ago

Hey @bstolinski. We need more information to resolve this issue but there hasn't been an update in 7 weekdays. I'm marking the issue as stale and if there are no new updates in the next 7 days I will close it automatically.

If you have more information that will help us get to the bottom of this, just add a comment!

google-oss-bot commented 1 year ago

Since there haven't been any recent updates here, I am going to close this issue.

@bstolinski if you're still experiencing this problem and want to continue the discussion just leave a comment here and we are happy to re-open this.

TomBeckett commented 1 year ago

@darshankawar still an on going issue.

I really must ask why was this closed?

darshankawar commented 1 year ago

Thanks for the update. The bot didn't seem to remove the wait label and that's why it somehow fell off my radar. Reopening.

darshankawar commented 1 year ago

@TomBeckett Can you provide us a minimal code sample that shows the reported behavior ?

darshankawar commented 1 year ago

Coming back to this issue, I tried to replicate using the details mentioned in original post https://github.com/firebase/flutterfire/issues/10346#issue-1562436796, but couldn't properly replicate it. Maybe I missed some steps to properly come up with a code sample, but will keep this issue open for team's attention.

russellwheatley commented 1 year ago

@bstolinski @TomBeckett - Could you provide a code sample, please?

I'll take a look at this. Thanks.

bstolinski commented 1 year ago

@russellwheatley yes, I will do it in the coming days

bstolinski commented 1 year ago

@russellwheatley here is the code with examples. Please note that for Android versions 5.0.8 and 5.1.1 behave identically, the difference is only visible on iOS. From what I have observed this change is responsible for it working differently.

firebase_dynamic_links 5.0.8 repo branch

https://user-images.githubusercontent.com/53336850/233939411-7d9c054c-ff4a-4755-93a8-a78e1b749092.mov

https://user-images.githubusercontent.com/53336850/233939441-c1761cf9-7dd9-4269-a33b-cc7548c35359.mov

firebase_dynamic_links 5.1.1 repo branch

https://user-images.githubusercontent.com/53336850/233939751-6ca73bed-a66b-4b35-b5ad-5c2b46d4e7cc.mov

https://user-images.githubusercontent.com/53336850/233939812-22ebe3ab-0f39-4f08-a673-22d278f8017e.mov

TomBeckett commented 1 year ago

@darshankawar any updates?

russellwheatley commented 10 months ago

Hi folks, we'd like to inform you that the Firebase Dynamic Links service will be shutdown on August 25, 2025. In the meantime, only critical or security issues will be fixed in the SDK.

More at firebase.google.com/support/dynamic-links-faq