search

firebase / flutterfire

šŸ”„ A collection of Firebase plugins for Flutter apps.
https://firebase.google.com/docs/flutter/setup
BSD 3-Clause "New" or "Revised" License
8.69k stars 3.97k forks source link

šŸ› [firebase_messaging] Android's `isApplicationForeground` check not working on managed devices #10869

Closed komaxx closed 5 months ago

komaxx commented 1 year ago

Bug report

On Android devices managed by some MDMs (obeserved with Samsung devices managed by Knox and ManageEngine), FlutterFire will invoke the onBackgroundMessage callback even when the app is in foreground.

I've dug a bit into the code and found the issue here: https://github.com/firebase/flutterfire/blob/5b1be86feaa0d5e3cfd3dbde6be628b748003461/packages/firebase_messaging/firebase_messaging/android/src/main/java/io/flutter/plugins/firebase/messaging/FlutterFirebaseMessagingUtils.java#L174

The check whether the app is running in foreground relies on ActivityManager.getRunningAppProcesses. While there are instances found in the web that describe this as possible way to check foreground status, the method's documentation clearly states that it is not intended for such purposes (see [official documentation](https://developer.android.com/reference/android/app/ActivityManager#getRunningAppProcesses()) ), and Android developers have recommended against it (see here).

Indeed, while this check failed extremely infrequently on non-managed devices, and only for some unlikely edge cases, it fails reliably on devices managed by the two MDMs that I have access to (ManageEngine and Knox). As a result, onBackgroundMessage is called in a freshly spawned isolate instead of onMessage. This, in turn causes bugs in my app.

While I understand that it can be argued that the fault here is with the MDMs, there are better ways to check foreground status on Android, using ActivityLifecycleCallbacks. See here for a good discussion: StackOverflow

Steps to reproduce

Steps to reproduce the behavior:

  1. Enroll a phone with ManageEngine
  2. Launch the messaging example app unmodified, just linked to a fresh Firebase project
  3. Send a push message to the app
  4. Observe in your logging view: Handling a background message .., which shows that processing in background was launched despite the app being in foreground

Expected behavior

When the app is in foreground on Android onMessage should be called, not onBackgroundMessage, even for devices managed by some MDM.

Sample project

The example project in the messaging repository itself is enough. [https://github.com/firebase/flutterfire/tree/master/packages/firebase_messaging/firebase_messaging/example]

Flutter doctor

Run flutter doctor and paste the output below:

Click To Expand ``` Doctor summary (to see all details, run flutter doctor -v): [āœ“] Flutter (Channel stable, 3.7.12, on macOS 12.6 21G115 darwin-x64, locale en-US) [āœ“] Android toolchain - develop for Android devices (Android SDK version 33.0.1) [āœ“] Xcode - develop for iOS and macOS (Xcode 14.2) [āœ“] Chrome - develop for the web [āœ“] Android Studio (version 2022.2) [āœ“] VS Code (version 1.77.3) [āœ“] Connected device (3 available) [āœ“] HTTP Host Availability ā€¢ No issues found! ```

Flutter dependencies

Run flutter pub deps -- --style=compact and paste the output below:

Click To Expand ``` Dart SDK 2.19.6 Flutter SDK 3.7.12 mobi_app_2 1.0.0+1 dependencies: - android_alarm_manager_plus 2.1.4 [flutter] - audioplayers 4.0.1 [audioplayers_android audioplayers_darwin audioplayers_linux audioplayers_platform_interface audioplayers_web audioplayers_windows file flutter http meta path_provider synchronized uuid] - collection 1.17.0 - crypto 3.0.2 [typed_data] - device_info_plus 8.2.2 [device_info_plus_platform_interface ffi file flutter flutter_web_plugins meta win32] - encrypt 5.0.1 [args asn1lib clock collection crypto pointycastle] - firebase_core 2.10.0 [firebase_core_platform_interface firebase_core_web flutter meta] - firebase_messaging 14.4.1 [firebase_core firebase_core_platform_interface firebase_messaging_platform_interface firebase_messaging_web flutter meta] - flutter 0.0.0 [characters collection js material_color_utilities meta vector_math sky_engine] - flutter_archive 5.0.0 [flutter] - flutter_background 1.2.0 [flutter plugin_platform_interface] - flutter_background_service 2.4.6 [flutter flutter_background_service_platform_interface flutter_background_service_android flutter_background_service_ios] - flutter_email_sender 5.2.0 [flutter] - flutter_inappwebview 5.7.2+3 [flutter] - flutter_local_notifications 14.0.0 [clock flutter flutter_local_notifications_linux flutter_local_notifications_platform_interface timezone] - flutter_localizations 0.0.0 [flutter intl characters clock collection js material_color_utilities meta path vector_math] - flutter_markdown 0.6.14 [flutter markdown meta path] - flutter_pdfview 1.2.9 [flutter] - flutter_phone_direct_caller 2.1.1 [flutter] - flutter_secure_storage 8.0.0 [flutter flutter_secure_storage_linux flutter_secure_storage_macos flutter_secure_storage_platform_interface flutter_secure_storage_web flutter_secure_storage_windows meta] - flutter_svg 2.0.5 [flutter vector_graphics vector_graphics_codec vector_graphics_compiler] - flutter_vibrate 1.3.0 [flutter] - flutter_volume_controller 1.2.5 [flutter flutter_plugin_android_lifecycle] - flutter_web_auth 0.5.0 [flutter flutter_web_plugins] - focus_detector 2.0.1 [flutter visibility_detector] - http 0.13.5 [async http_parser meta path] - image_picker 0.8.7+4 [flutter image_picker_android image_picker_for_web image_picker_ios image_picker_platform_interface] - intl 0.18.1 [clock meta path] - intl_utils 2.8.2 [analyzer archive args dart_style http intl path petitparser yaml] - location 4.4.0 [flutter location_platform_interface location_web] - native_plugin 0.0.1 [flutter plugin_platform_interface] - package_info_plus 3.1.2 [ffi flutter flutter_web_plugins http meta path package_info_plus_platform_interface win32] - path_provider 2.0.14 [flutter path_provider_android path_provider_foundation path_provider_linux path_provider_platform_interface path_provider_windows] - provider 6.0.5 [collection flutter nested] - rxdart 0.27.7 - sensors_plus 2.0.5 [flutter flutter_web_plugins sensors_plus_platform_interface] - share_plus 6.3.4 [cross_file meta mime flutter flutter_web_plugins share_plus_platform_interface file url_launcher_web url_launcher_windows url_launcher_linux url_launcher_platform_interface ffi win32] - shared_preferences 2.1.0 [flutter shared_preferences_android shared_preferences_foundation shared_preferences_linux shared_preferences_platform_interface shared_preferences_web shared_preferences_windows] - shimmer 2.0.0 [flutter] - sip_ua 0.5.6 [collection crypto flutter_webrtc intl logger parser_error path random_string recase sdp_transform uuid] - timeago 3.4.0 [intl] - url_launcher 6.1.10 [flutter url_launcher_android url_launcher_ios url_launcher_linux url_launcher_macos url_launcher_platform_interface url_launcher_web url_launcher_windows] - video_player 2.6.1 [flutter html video_player_android video_player_avfoundation video_player_platform_interface video_player_web] dev dependencies: - build_runner 2.3.3 [args async analyzer build build_config build_daemon build_resolvers build_runner_core code_builder collection crypto dart_style frontend_server_client glob graphs http_multi_server io js logging meta mime package_config path pool pub_semver pubspec_parse shelf shelf_web_socket stack_trace stream_transform timing watcher web_socket_channel yaml] - dart_code_metrics 5.7.2 [analyzer analyzer_plugin ansicolor args collection crypto dart_code_metrics_presets file glob html http meta path platform pub_updater source_span uuid xml yaml] - fake_async 1.3.1 [clock collection] - flutter_gen_runner 5.3.0 [flutter_gen_core build collection crypto glob path] - flutter_launcher_icons 0.13.1 [args checked_yaml cli_util image json_annotation path yaml] - flutter_lints 2.0.1 [lints] - flutter_test 0.0.0 [flutter test_api path fake_async clock stack_trace vector_math async boolean_selector characters collection js matcher material_color_utilities meta source_span stream_channel string_scanner term_glyph] dependency overrides: - collection 1.17.0 - flutter_pdfview 1.2.9 [flutter] - intl 0.18.1 [clock meta path] transitive dependencies: - _fe_analyzer_shared 58.0.0 [meta] - _flutterfire_internals 1.1.1 [collection firebase_core firebase_core_platform_interface flutter meta] - analyzer 5.10.0 [_fe_analyzer_shared collection convert crypto glob meta package_config path pub_semver source_span watcher yaml] - analyzer_plugin 0.11.2 [analyzer collection dart_style pub_semver yaml] - ansicolor 2.0.1 - archive 3.3.7 [crypto path pointycastle] - args 2.4.0 - asn1lib 1.4.0 - async 2.10.0 [collection meta] - audioplayers_android 3.0.1 [audioplayers_platform_interface flutter] - audioplayers_darwin 4.0.1 [audioplayers_platform_interface flutter] - audioplayers_linux 2.0.1 [audioplayers_platform_interface flutter] - audioplayers_platform_interface 5.0.0 [flutter meta plugin_platform_interface] - audioplayers_web 3.0.1 [audioplayers_platform_interface flutter flutter_web_plugins js] - audioplayers_windows 2.0.1 [audioplayers_platform_interface flutter] - boolean_selector 2.1.1 [source_span string_scanner] - build 2.3.1 [analyzer async convert crypto glob logging meta path] - build_config 1.1.1 [checked_yaml json_annotation path pubspec_parse yaml] - build_daemon 3.1.1 [built_collection built_value http_multi_server logging path pool shelf shelf_web_socket stream_transform watcher web_socket_channel] - build_resolvers 2.2.0 [analyzer async build collection crypto graphs logging path package_config pool pub_semver stream_transform yaml] - build_runner_core 7.2.7 [async build build_config build_resolvers collection convert crypto glob graphs json_annotation logging meta path package_config pool timing watcher yaml] - built_collection 5.1.1 - built_value 8.4.4 [built_collection collection fixnum meta] - characters 1.2.1 - checked_yaml 2.0.2 [json_annotation source_span yaml] - cli_util 0.4.0 [meta path] - clock 1.1.1 - code_builder 4.4.0 [built_collection built_value collection matcher meta] - color 3.0.0 - convert 3.1.1 [typed_data] - cross_file 0.3.3+4 [js meta] - csslib 0.17.2 [source_span] - dart_code_metrics_presets 1.6.0 - dart_style 2.3.0 [analyzer args path pub_semver source_span] - dart_webrtc 1.0.16 [js platform_detect webrtc_interface] - dartx 1.1.0 [characters collection crypto meta path time] - dbus 0.7.8 [args ffi meta xml] - device_info_plus_platform_interface 7.0.0 [flutter meta plugin_platform_interface] - ffi 2.0.1 - file 6.1.4 [meta path] - firebase_core_platform_interface 4.6.0 [collection flutter flutter_test meta plugin_platform_interface] - firebase_core_web 2.3.0 [firebase_core_platform_interface flutter flutter_web_plugins js meta] - firebase_messaging_platform_interface 4.3.1 [_flutterfire_internals firebase_core flutter meta plugin_platform_interface] - firebase_messaging_web 3.3.1 [_flutterfire_internals firebase_core firebase_core_web firebase_messaging_platform_interface flutter flutter_web_plugins js meta] - fixnum 1.1.0 - flutter_background_service_android 3.0.3 [flutter flutter_background_service_platform_interface] - flutter_background_service_ios 2.4.0 [flutter flutter_background_service_platform_interface] - flutter_background_service_platform_interface 2.2.0 [flutter platform plugin_platform_interface] - flutter_gen_core 5.3.0 [path yaml mime xml dartx color collection json_annotation glob dart_style analyzer args pub_semver source_span] - flutter_local_notifications_linux 4.0.0 [dbus ffi flutter flutter_local_notifications_platform_interface path xdg_directories] - flutter_local_notifications_platform_interface 7.0.0 [flutter plugin_platform_interface] - flutter_plugin_android_lifecycle 2.0.9 [flutter] - flutter_secure_storage_linux 1.1.3 [flutter flutter_secure_storage_platform_interface] - flutter_secure_storage_macos 3.0.0 [flutter flutter_secure_storage_platform_interface] - flutter_secure_storage_platform_interface 1.0.1 [flutter plugin_platform_interface] - flutter_secure_storage_web 1.1.1 [flutter flutter_secure_storage_platform_interface flutter_web_plugins js] - flutter_secure_storage_windows 2.0.0 [flutter flutter_secure_storage_platform_interface] - flutter_web_plugins 0.0.0 [flutter js characters collection material_color_utilities meta vector_math] - flutter_webrtc 0.9.26 [dart_webrtc flutter path_provider webrtc_interface] - frontend_server_client 3.2.0 [async path] - glob 2.1.1 [async collection file path string_scanner] - graphs 2.2.0 [collection] - html 0.15.2 [csslib source_span] - http_multi_server 3.2.1 [async] - http_parser 4.0.2 [collection source_span string_scanner typed_data] - image 4.0.15 [archive meta xml] - image_picker_android 0.8.6+7 [flutter flutter_plugin_android_lifecycle image_picker_platform_interface] - image_picker_for_web 2.1.12 [flutter flutter_web_plugins image_picker_platform_interface] - image_picker_ios 0.8.7+3 [flutter image_picker_platform_interface] - image_picker_platform_interface 2.6.3 [cross_file flutter http plugin_platform_interface] - io 1.0.4 [meta path string_scanner] - js 0.6.5 [meta] - json_annotation 4.8.0 [meta] - lints 2.0.1 - lists 1.0.1 [meta] - location_platform_interface 2.3.0 [flutter meta plugin_platform_interface] - location_web 3.1.1 [flutter flutter_web_plugins http_parser js location_platform_interface meta] - logger 1.3.0 - logging 1.1.1 - markdown 7.0.2 [args meta] - matcher 0.12.13 [meta stack_trace] - material_color_utilities 0.2.0 - meta 1.8.0 - mime 1.0.4 - nested 1.0.0 [flutter] - package_config 2.1.0 [path] - package_info_plus_platform_interface 2.0.1 [flutter meta plugin_platform_interface] - parser_error 0.2.0 [text] - path 1.8.2 - path_parsing 1.0.1 [vector_math meta] - path_provider_android 2.0.25 [flutter path_provider_platform_interface] - path_provider_foundation 2.2.2 [flutter path_provider_platform_interface] - path_provider_linux 2.1.10 [ffi flutter path path_provider_platform_interface xdg_directories] - path_provider_platform_interface 2.0.6 [flutter platform plugin_platform_interface] - path_provider_windows 2.1.6 [ffi flutter path path_provider_platform_interface win32] - petitparser 5.1.0 [meta] - platform 3.1.0 - platform_detect 2.0.7 [meta pub_semver] - plugin_platform_interface 2.1.4 [meta] - pointycastle 3.7.3 [collection convert js] - pool 1.5.1 [async stack_trace] - process 4.2.4 [file path platform] - pub_semver 2.1.3 [collection meta] - pub_updater 0.2.4 [http json_annotation process] - pubspec_parse 1.2.2 [checked_yaml collection json_annotation pub_semver yaml] - random_string 2.3.1 - recase 4.1.0 - sdp_transform 0.3.2 - sensors_plus_platform_interface 1.1.3 [flutter meta plugin_platform_interface] - share_plus_platform_interface 3.2.1 [cross_file flutter meta mime plugin_platform_interface path_provider uuid] - shared_preferences_android 2.1.2 [flutter shared_preferences_platform_interface] - shared_preferences_foundation 2.2.1 [flutter shared_preferences_platform_interface] - shared_preferences_linux 2.2.0 [file flutter path path_provider_linux path_provider_platform_interface shared_preferences_platform_interface] - shared_preferences_platform_interface 2.2.0 [flutter plugin_platform_interface] - shared_preferences_web 2.1.0 [flutter flutter_web_plugins shared_preferences_platform_interface] - shared_preferences_windows 2.2.0 [file flutter path path_provider_platform_interface path_provider_windows shared_preferences_platform_interface] - shelf 1.4.0 [async collection http_parser path stack_trace stream_channel] - shelf_web_socket 1.0.3 [shelf stream_channel web_socket_channel] - sky_engine 0.0.99 - source_span 1.9.1 [collection path term_glyph] - stack_trace 1.11.0 [path] - stream_channel 2.1.1 [async] - stream_transform 2.1.0 - string_scanner 1.2.0 [source_span] - synchronized 3.1.0 - term_glyph 1.2.1 - test_api 0.4.16 [async boolean_selector collection meta source_span stack_trace stream_channel string_scanner term_glyph matcher] - text 0.2.0 [lists] - time 2.1.3 [clock] - timezone 0.9.2 [path] - timing 1.0.1 [json_annotation] - typed_data 1.3.1 [collection] - url_launcher_android 6.0.27 [flutter url_launcher_platform_interface] - url_launcher_ios 6.1.4 [flutter url_launcher_platform_interface] - url_launcher_linux 3.0.5 [flutter url_launcher_platform_interface] - url_launcher_macos 3.0.5 [flutter url_launcher_platform_interface] - url_launcher_platform_interface 2.1.2 [flutter plugin_platform_interface] - url_launcher_web 2.0.16 [flutter flutter_web_plugins url_launcher_platform_interface] - url_launcher_windows 3.0.6 [flutter url_launcher_platform_interface] - uuid 3.0.7 [crypto] - vector_graphics 1.1.5 [flutter vector_graphics_codec] - vector_graphics_codec 1.1.5 - vector_graphics_compiler 1.1.5 [args meta path_parsing xml vector_graphics_codec] - vector_math 2.1.4 - video_player_android 2.4.4 [flutter video_player_platform_interface] - video_player_avfoundation 2.4.4 [flutter video_player_platform_interface] - video_player_platform_interface 6.1.0 [flutter plugin_platform_interface] - video_player_web 2.0.16 [flutter flutter_web_plugins video_player_platform_interface] - visibility_detector 0.2.2 [flutter] - watcher 1.0.2 [async path] - web_socket_channel 2.4.0 [async crypto stream_channel] - webrtc_interface 1.0.13 - win32 3.1.4 [ffi] - xdg_directories 1.0.0 [meta path process] - xml 6.2.2 [collection meta petitparser] - yaml 3.1.1 [collection source_span string_scanner]```
darshankawar commented 1 year ago

Thanks for the report. I don't have the said setup with ManageEngine / device to verify this, so will keep it open and label for team's input for current vs expected behavior.

/cc @Lyokone

yeikel16 commented 1 year ago

Hi guys, the opposite happens to me, the onMessage stream is also notified when the app is in the background, this causes me to get two notifications of the same type.

This happens to me with the versions: firebase_core: ^2.15.0 firebase_messaging: ^14.6.5 firebase_crashlytics: ^3.3.4

madduruashok commented 1 year ago

Hi guys, the opposite happens to me, the onMessage stream is also notified when the app is in the background, this causes me to get two notifications of the same type.

This happens to me with the versions: firebase_core: ^2.15.0 firebase_messaging: ^14.6.5 firebase_crashlytics: ^3.3.4

same happening for me too. Got the first message via background handler (app is in background), then second message via foreground handler (via onMessage even when the app is still in background state)

package versions: firebase_core: 2.13.1 firebase_messaging: 14.6.2

TarekkMA commented 5 months ago

Hi @komaxx ,

Thank you for your report! Since this issue was opened, the implementation details have changed significantly. If you feel that this issue is still relevant, please feel free to open a new issue with updated context. We appreciate your understanding and support.

komaxx commented 5 months ago

@TarekkMA I've by now moved on to a different solution so can't say if it still exists or not. Anyway, thank you for updating this probably outdated ticket :)