firebase / flutterfire

πŸ”₯ A collection of Firebase plugins for Flutter apps.
https://firebase.google.com/docs/flutter/setup
BSD 3-Clause "New" or "Revised" License
8.63k stars 3.95k forks source link

πŸ› [firebase_app_check] App attest seems to not be supported on MacOS and no fallback to device check #10934

Closed Tom3652 closed 2 months ago

Tom3652 commented 1 year ago

Bug report

Describe the bug

I have a live app on MacOS store that has this error : Capture d’écran 2023-05-10 aΜ€ 10 56 41

My MacOS app is using the same "key" than my iOS app in App Check and here is the code used to initialize app check :

FirebaseAppCheck.instance.activate(
    appleProvider: kDebugMode ? AppleProvider.debug : AppleProvider.appAttestWithDeviceCheckFallback,
  );

This error occurs probably when calling : FirebaseAppCheck.instance.getToken() (it's in my live app i have this error, and i have not setup the debug token on MacOS).

But this is the only code i use for App Check client side.

Expected behavior

App Attest seems to not be supported on MacOS, but the AppleProvider.appAttestWithDeviceCheckFallback should fallback to device check and not throw this error. If neither App attest or device is support on MacOS, then the plugin should not display it, otherwise it should be working as on iOS

Note : on MacOS, there are no capabilities "App Attest" or "Device check" compared to iOS.

Flutter doctor

Run flutter doctor and paste the output below:

Click To Expand ``` Doctor summary (to see all details, run flutter doctor -v): [βœ“] Flutter (Channel stable, 3.7.12, on macOS 13.3.1 22E772610a darwin-x64, locale fr-FR) Checking Android licenses is taking an unexpectedly long time...[βœ“] Android toolchain - develop for Android devices (Android SDK version 33.0.1) [βœ“] Xcode - develop for iOS and macOS (Xcode 14.3) [βœ“] Chrome - develop for the web [βœ“] Android Studio (version 2022.2) [βœ“] VS Code (version 1.77.3) [βœ“] Connected device (5 available) [βœ“] HTTP Host Availability β€’ No issues found! ```

Flutter dependencies

Run flutter pub deps -- --style=compact and paste the output below:

Click To Expand ``` Dart SDK 2.19.6 Flutter SDK 3.7.12 myapp 1.2.0 dependencies: - app_settings 4.2.0 [flutter] - audio_session 0.1.13 [flutter flutter_web_plugins rxdart meta] - audio_waveforms 1.0.4 [flutter] - audioplayers 4.0.1 [audioplayers_android audioplayers_darwin audioplayers_linux audioplayers_platform_interface audioplayers_web audioplayers_windows file flutter http meta path_provider synchronized uuid] - auto_size_text 3.0.0 [flutter] - cached_network_image 3.2.3 [flutter flutter_cache_manager octo_image cached_network_image_platform_interface cached_network_image_web] - collection 1.17.0 - connectivity_plus 3.0.6 [flutter flutter_web_plugins connectivity_plus_platform_interface js meta nm] - crypto 3.0.3 [typed_data] - cupertino_icons 1.0.5 - desktop_drop 0.4.1 [flutter flutter_web_plugins cross_file] - dio 5.1.1 [http_parser meta path] - extended_image 7.0.2 [extended_image_library flutter meta] - file_selector 0.9.2+5 [file_selector_ios file_selector_linux file_selector_macos file_selector_platform_interface file_selector_web file_selector_windows flutter] - firebase_analytics 10.3.0 [firebase_analytics_platform_interface firebase_analytics_web firebase_core firebase_core_platform_interface flutter] - firebase_app_check 0.1.3 [firebase_app_check_platform_interface firebase_app_check_web firebase_core firebase_core_platform_interface flutter] - firebase_auth 4.5.0 [firebase_auth_platform_interface firebase_auth_web firebase_core firebase_core_platform_interface flutter meta] - firebase_core 2.11.0 [firebase_core_platform_interface firebase_core_web flutter meta] - firebase_crashlytics 3.2.0 [firebase_core firebase_core_platform_interface firebase_crashlytics_platform_interface flutter stack_trace] - firebase_messaging 14.5.0 [firebase_core firebase_core_platform_interface firebase_messaging_platform_interface firebase_messaging_web flutter meta] - firebase_performance 0.9.1+2 [firebase_core firebase_core_platform_interface firebase_performance_platform_interface firebase_performance_web flutter] - flutter 0.0.0 [characters collection js material_color_utilities meta vector_math sky_engine] - flutter_app_badger 1.5.0 [flutter] - flutter_calendar_carousel 2.4.2 [intl flutter] - flutter_image_compress 1.1.3 [flutter] - flutter_localizations 0.0.0 [flutter intl characters clock collection js material_color_utilities meta path vector_math] - flutter_secure_storage 8.0.0 [flutter flutter_secure_storage_linux flutter_secure_storage_macos flutter_secure_storage_platform_interface flutter_secure_storage_web flutter_secure_storage_windows meta] - flutter_staggered_grid_view 0.6.2 [flutter] - gallery_saver 2.3.2 [flutter path_provider http path] - google_sign_in 6.1.0 [flutter google_sign_in_android google_sign_in_ios google_sign_in_platform_interface google_sign_in_web] - hive_flutter 1.1.0 [flutter hive path_provider path] - http 0.13.6 [async http_parser meta] - image_editor 1.3.0 [flutter image_editor_platform_interface image_editor_common] - image_picker 0.8.7+4 [flutter image_picker_android image_picker_for_web image_picker_ios image_picker_platform_interface] - in_app_purchase 3.1.5 [flutter in_app_purchase_android in_app_purchase_platform_interface in_app_purchase_storekit] - in_app_review 2.0.6 [flutter in_app_review_platform_interface] - linkify 4.1.0 - local_auth 2.1.6 [flutter local_auth_android local_auth_ios local_auth_platform_interface local_auth_windows] - maps_launcher 2.2.0 [flutter flutter_web_plugins url_launcher] - path_provider 2.0.14 [flutter path_provider_android path_provider_foundation path_provider_linux path_provider_platform_interface path_provider_windows] - permission_handler 10.2.0 [flutter meta permission_handler_android permission_handler_apple permission_handler_windows permission_handler_platform_interface] - provider 6.0.5 [collection flutter nested] - pull_to_refresh_flutter3 2.0.1 [flutter] - purchases_flutter 4.12.0 [flutter freezed_annotation json_annotation] - record 4.4.4 [flutter record_platform_interface record_web record_windows record_macos record_linux] - rive 0.10.4 [collection flutter flutter_web_plugins http meta plugin_platform_interface rive_common] - share_plus 6.3.4 [cross_file meta mime flutter flutter_web_plugins share_plus_platform_interface file url_launcher_web url_launcher_windows url_launcher_linux url_launcher_platform_interface ffi win32] - shared_preferences 2.1.0 [flutter shared_preferences_android shared_preferences_foundation shared_preferences_linux shared_preferences_platform_interface shared_preferences_web shared_preferences_windows] - sign_in_with_apple 4.3.0 [flutter meta sign_in_with_apple_platform_interface sign_in_with_apple_web] - url_launcher 6.1.10 [flutter url_launcher_android url_launcher_ios url_launcher_linux url_launcher_macos url_launcher_platform_interface url_launcher_web url_launcher_windows] - uuid 3.0.7 [crypto] dev dependencies: - build_runner 2.3.3 [args async analyzer build build_config build_daemon build_resolvers build_runner_core code_builder collection crypto dart_style frontend_server_client glob graphs http_multi_server io js logging meta mime package_config path pool pub_semver pubspec_parse shelf shelf_web_socket stack_trace stream_transform timing watcher web_socket_channel yaml] - flutter_launcher_icons 0.13.1 [args checked_yaml cli_util image json_annotation path yaml] - flutter_lints 2.0.1 [lints] - flutter_test 0.0.0 [flutter test_api path fake_async clock stack_trace vector_math async boolean_selector characters collection js matcher material_color_utilities meta source_span stream_channel string_scanner term_glyph] - hive_generator 2.0.0 [build source_gen hive analyzer source_helper] transitive dependencies: - _fe_analyzer_shared 59.0.0 [meta] - _flutterfire_internals 1.2.0 [collection firebase_core firebase_core_platform_interface flutter meta] - analyzer 5.11.1 [_fe_analyzer_shared collection convert crypto glob meta package_config path pub_semver source_span watcher yaml] - archive 3.3.7 [crypto path pointycastle] - args 2.4.1 - async 2.10.0 [collection meta] - audioplayers_android 3.0.1 [audioplayers_platform_interface flutter] - audioplayers_darwin 4.0.1 [audioplayers_platform_interface flutter] - audioplayers_linux 2.0.1 [audioplayers_platform_interface flutter] - audioplayers_platform_interface 5.0.0 [flutter meta plugin_platform_interface] - audioplayers_web 3.0.1 [audioplayers_platform_interface flutter flutter_web_plugins js] - audioplayers_windows 2.0.1 [audioplayers_platform_interface flutter] - boolean_selector 2.1.1 [source_span string_scanner] - build 2.3.1 [analyzer async convert crypto glob logging meta path] - build_config 1.1.1 [checked_yaml json_annotation path pubspec_parse yaml] - build_daemon 3.1.1 [built_collection built_value http_multi_server logging path pool shelf shelf_web_socket stream_transform watcher web_socket_channel] - build_resolvers 2.2.0 [analyzer async build collection crypto graphs logging path package_config pool pub_semver stream_transform yaml] - build_runner_core 7.2.7 [async build build_config build_resolvers collection convert crypto glob graphs json_annotation logging meta path package_config pool timing watcher yaml] - built_collection 5.1.1 - built_value 8.5.0 [built_collection collection fixnum meta] - cached_network_image_platform_interface 2.0.0 [flutter flutter_cache_manager] - cached_network_image_web 1.0.2 [flutter flutter_cache_manager cached_network_image_platform_interface] - characters 1.2.1 - checked_yaml 2.0.3 [json_annotation source_span yaml] - cli_util 0.4.0 [meta path] - clock 1.1.1 - code_builder 4.4.0 [built_collection built_value collection matcher meta] - connectivity_plus_platform_interface 1.2.4 [flutter meta plugin_platform_interface] - convert 3.1.1 [typed_data] - cross_file 0.3.3+4 [js meta] - dart_style 2.3.1 [analyzer args path pub_semver source_span] - dbus 0.7.8 [args ffi meta xml] - extended_image_library 3.4.2 [crypto flutter http_client_helper path path_provider] - fake_async 1.3.1 [clock collection] - ffi 2.0.1 - file 6.1.4 [meta path] - file_selector_ios 0.5.1+4 [file_selector_platform_interface flutter] - file_selector_linux 0.9.1+3 [cross_file file_selector_platform_interface flutter] - file_selector_macos 0.9.2 [cross_file file_selector_platform_interface flutter] - file_selector_platform_interface 2.5.0 [cross_file flutter http plugin_platform_interface] - file_selector_web 0.9.0+4 [file_selector_platform_interface flutter flutter_web_plugins] - file_selector_windows 0.9.2 [cross_file file_selector_platform_interface flutter] - firebase_analytics_platform_interface 3.5.0 [_flutterfire_internals firebase_core flutter meta plugin_platform_interface] - firebase_analytics_web 0.5.3 [_flutterfire_internals firebase_analytics_platform_interface firebase_core firebase_core_web flutter flutter_web_plugins js] - firebase_app_check_platform_interface 0.0.7 [_flutterfire_internals firebase_core flutter meta plugin_platform_interface] - firebase_app_check_web 0.0.9 [_flutterfire_internals firebase_app_check_platform_interface firebase_core firebase_core_web flutter flutter_web_plugins js] - firebase_auth_platform_interface 6.14.0 [_flutterfire_internals collection firebase_core flutter meta plugin_platform_interface] - firebase_auth_web 5.4.0 [firebase_auth_platform_interface firebase_core firebase_core_web flutter flutter_web_plugins http_parser intl js meta] - firebase_core_platform_interface 4.7.0 [collection flutter flutter_test meta plugin_platform_interface] - firebase_core_web 2.4.0 [firebase_core_platform_interface flutter flutter_web_plugins js meta] - firebase_crashlytics_platform_interface 3.5.0 [_flutterfire_internals collection firebase_core flutter meta plugin_platform_interface] - firebase_messaging_platform_interface 4.4.0 [_flutterfire_internals firebase_core flutter meta plugin_platform_interface] - firebase_messaging_web 3.4.0 [_flutterfire_internals firebase_core firebase_core_web firebase_messaging_platform_interface flutter flutter_web_plugins js meta] - firebase_performance_platform_interface 0.1.3 [_flutterfire_internals firebase_core flutter plugin_platform_interface] - firebase_performance_web 0.1.3 [_flutterfire_internals firebase_core firebase_core_web firebase_performance_platform_interface flutter flutter_web_plugins js] - fixnum 1.1.0 - flutter_blurhash 0.7.0 [flutter] - flutter_cache_manager 3.3.0 [clock collection file flutter http path path_provider pedantic rxdart sqflite uuid] - flutter_plugin_android_lifecycle 2.0.13 [flutter] - flutter_secure_storage_linux 1.1.3 [flutter flutter_secure_storage_platform_interface] - flutter_secure_storage_macos 3.0.0 [flutter flutter_secure_storage_platform_interface] - flutter_secure_storage_platform_interface 1.0.1 [flutter plugin_platform_interface] - flutter_secure_storage_web 1.1.1 [flutter flutter_secure_storage_platform_interface flutter_web_plugins js] - flutter_secure_storage_windows 2.0.0 [flutter flutter_secure_storage_platform_interface] - flutter_web_plugins 0.0.0 [flutter js characters collection material_color_utilities meta vector_math] - freezed_annotation 2.2.0 [collection json_annotation meta] - frontend_server_client 3.2.0 [async path] - glob 2.1.1 [async collection file path string_scanner] - google_identity_services_web 0.2.1 [js meta] - google_sign_in_android 6.1.14 [flutter google_sign_in_platform_interface] - google_sign_in_ios 5.6.2 [flutter google_sign_in_platform_interface] - google_sign_in_platform_interface 2.4.0 [flutter plugin_platform_interface quiver] - google_sign_in_web 0.12.0 [flutter flutter_web_plugins google_identity_services_web google_sign_in_platform_interface http js] - graphs 2.2.0 [collection] - hive 2.2.3 [meta crypto] - http_client_helper 2.0.3 [http] - http_multi_server 3.2.1 [async] - http_parser 4.0.2 [collection source_span string_scanner typed_data] - image 4.0.16 [archive meta xml] - image_editor_common 1.0.1 [flutter image_editor_platform_interface] - image_editor_platform_interface 1.0.1 [flutter platform plugin_platform_interface] - image_picker_android 0.8.6+11 [flutter flutter_plugin_android_lifecycle image_picker_platform_interface] - image_picker_for_web 2.1.12 [flutter flutter_web_plugins image_picker_platform_interface] - image_picker_ios 0.8.7+3 [flutter image_picker_platform_interface] - image_picker_platform_interface 2.6.3 [cross_file flutter http plugin_platform_interface] - in_app_purchase_android 0.2.5+4 [collection flutter in_app_purchase_platform_interface json_annotation] - in_app_purchase_platform_interface 1.3.3 [flutter plugin_platform_interface] - in_app_purchase_storekit 0.3.6+3 [collection flutter in_app_purchase_platform_interface json_annotation] - in_app_review_platform_interface 2.0.4 [flutter url_launcher plugin_platform_interface platform] - intl 0.17.0 [clock path] - io 1.0.4 [meta path string_scanner] - js 0.6.5 [meta] - json_annotation 4.8.1 [meta] - lints 2.0.1 - local_auth_android 1.0.28 [flutter flutter_plugin_android_lifecycle intl local_auth_platform_interface] - local_auth_ios 1.1.1 [flutter intl local_auth_platform_interface] - local_auth_platform_interface 1.0.7 [flutter plugin_platform_interface] - local_auth_windows 1.0.8 [flutter local_auth_platform_interface] - logging 1.1.1 - matcher 0.12.13 [meta stack_trace] - material_color_utilities 0.2.0 - meta 1.8.0 - mime 1.0.4 - nested 1.0.0 [flutter] - nm 0.5.0 [dbus] - octo_image 1.0.2 [flutter flutter_blurhash] - package_config 2.1.0 [path] - path 1.8.2 - path_provider_android 2.0.27 [flutter path_provider_platform_interface] - path_provider_foundation 2.2.2 [flutter path_provider_platform_interface] - path_provider_linux 2.1.10 [ffi flutter path path_provider_platform_interface xdg_directories] - path_provider_platform_interface 2.0.6 [flutter platform plugin_platform_interface] - path_provider_windows 2.1.6 [ffi flutter path path_provider_platform_interface win32] - pedantic 1.11.1 - permission_handler_android 10.2.0 [flutter permission_handler_platform_interface] - permission_handler_apple 9.0.8 [flutter permission_handler_platform_interface] - permission_handler_platform_interface 3.9.0 [flutter meta plugin_platform_interface] - permission_handler_windows 0.1.2 [flutter permission_handler_platform_interface] - petitparser 5.1.0 [meta] - platform 3.1.0 - plugin_platform_interface 2.1.4 [meta] - pointycastle 3.7.3 [collection convert js] - pool 1.5.1 [async stack_trace] - process 4.2.4 [file path platform] - pub_semver 2.1.4 [collection meta] - pubspec_parse 1.2.3 [checked_yaml collection json_annotation pub_semver yaml] - quiver 3.2.1 [matcher] - record_linux 0.4.1 [flutter record_platform_interface path] - record_macos 0.2.2 [flutter record_platform_interface] - record_platform_interface 0.5.0 [flutter plugin_platform_interface] - record_web 0.5.0 [flutter flutter_web_plugins record_platform_interface] - record_windows 0.7.1 [flutter record_platform_interface path] - rive_common 0.0.5 [flutter flutter_web_plugins collection ffi graphs http meta plugin_platform_interface] - rxdart 0.27.7 - share_plus_platform_interface 3.2.1 [cross_file flutter meta mime plugin_platform_interface path_provider uuid] - shared_preferences_android 2.1.4 [flutter shared_preferences_platform_interface] - shared_preferences_foundation 2.2.1 [flutter shared_preferences_platform_interface] - shared_preferences_linux 2.2.0 [file flutter path path_provider_linux path_provider_platform_interface shared_preferences_platform_interface] - shared_preferences_platform_interface 2.2.0 [flutter plugin_platform_interface] - shared_preferences_web 2.1.0 [flutter flutter_web_plugins shared_preferences_platform_interface] - shared_preferences_windows 2.2.0 [file flutter path path_provider_platform_interface path_provider_windows shared_preferences_platform_interface] - shelf 1.4.1 [async collection http_parser path stack_trace stream_channel] - shelf_web_socket 1.0.4 [shelf stream_channel web_socket_channel] - sign_in_with_apple_platform_interface 1.0.0 [flutter plugin_platform_interface meta] - sign_in_with_apple_web 1.0.1 [flutter flutter_web_plugins sign_in_with_apple_platform_interface js] - sky_engine 0.0.99 - source_gen 1.2.7 [analyzer async build dart_style glob path source_span yaml] - source_helper 1.3.3 [analyzer collection source_gen] - source_span 1.9.1 [collection path term_glyph] - sqflite 2.2.8+1 [flutter sqflite_common path] - sqflite_common 2.4.5 [synchronized path meta] - stack_trace 1.11.0 [path] - stream_channel 2.1.1 [async] - stream_transform 2.1.0 - string_scanner 1.2.0 [source_span] - synchronized 3.1.0 - term_glyph 1.2.1 - test_api 0.4.16 [async boolean_selector collection meta source_span stack_trace stream_channel string_scanner term_glyph matcher] - timing 1.0.1 [json_annotation] - typed_data 1.3.1 [collection] - url_launcher_android 6.0.31 [flutter url_launcher_platform_interface] - url_launcher_ios 6.1.4 [flutter url_launcher_platform_interface] - url_launcher_linux 3.0.5 [flutter url_launcher_platform_interface] - url_launcher_macos 3.0.5 [flutter url_launcher_platform_interface] - url_launcher_platform_interface 2.1.2 [flutter plugin_platform_interface] - url_launcher_web 2.0.16 [flutter flutter_web_plugins url_launcher_platform_interface] - url_launcher_windows 3.0.6 [flutter url_launcher_platform_interface] - vector_math 2.1.4 - watcher 1.0.2 [async path] - web_socket_channel 2.4.0 [async crypto stream_channel] - win32 3.1.4 [ffi] - xdg_directories 1.0.0 [meta path process] - xml 6.2.2 [collection meta petitparser] - yaml 3.1.2 [collection source_span string_scanner] ```

darshankawar commented 1 year ago

Thanks for the report @Tom3652

App Attest seems to not be supported on MacOS,

This seems to be the case currently, as I also looked at plugin installation guide but it doesn't have section for macOS: https://firebase.google.com/docs/app-check

Also, the plugin may not be supporting desktop platform yet, as this desktop repo doesn't have the app_check plugin related details yet: https://github.com/FirebaseExtended/flutterfire_desktop

Another similar / related issue: https://github.com/firebase/flutterfire/issues/10463

Tom3652 commented 1 year ago

I must say that the app check debug is working fine on MacOS, simply not in release mode. Is the https://github.com/FirebaseExtended/flutterfire_desktop an official package from the FlutterFire team ?

andyshephard commented 10 months ago

Has there been any confirmation yet that macOS works with App Attest or DeviceCheck?

TarekkMA commented 2 months ago

Hey @Tom3652,

Thank you for your report! Since this issue was opened, the implementation details have changed significantly. If you feel that this issue is still relevant, please feel free to open a new issue with updated context. We appreciate your understanding and support.