search

firebase / flutterfire

🔥 A collection of Firebase plugins for Flutter apps.
https://firebase.google.com/docs/flutter/setup
BSD 3-Clause "New" or "Revised" License
8.73k stars 3.98k forks source link

🐛 [cloud_firestore] garbage collector triggered when CACHE_SIZE_UNLIMITED is set on iOS #12315

Open BradKwon opened 9 months ago

BradKwon commented 9 months ago

Bug report

Describe the bug Hi FlutterFire team,

I brought this from "discussions" as there has been no feedback and it seems this is a possible bug.

It looks like the cache garbage collector is triggered even though CACHE_SIZE_UNLIMITED is set for iOS when persistenceEnabled is true.

I noticed that there was a crash fix and a change to CACHE_SIZE_UNLIMITED from v4.8.2.

As far as I understand based on the current implementation of iOS code on the master branch, if cacheSizeBytes is set to CACHE_SIZE_UNLIMITED (= -1), cache setting is set to the max. cache size because it seems there was an issue with kFIRFirestoreCacheSizeUnlimited.

The Firestore doc and https://github.com/firebase/firebase-ios-sdk/discussions/12277#discussioncomment-8152897 say that the cache size should be set to CACHE_SIZE_UNLIMITED (= -1) in order to disable clean-up. However, as it is set to max. cache size in cloud_firestore, I assume that this clean-up will happen when the cache size reaches to the max. size.

Furthermore, the Android implementation still sets the cache size to CACHE_SIZE_UNLIMITED if the cache size is -1, which is different to the iOS implementation. Because of this, clean-up on Android would not take place.

Some of my iOS app users are reporting data loss after I upgraded cloud_firestore package from v4.1.0 to v4.9.3. I assume that it is because of the cache clean-up. And I see that the implementation hasn't been changed since v4.8.2.

I look forward to your feedback.

Thank you and best regards,

Steps to reproduce

Unfortunately, I think it is hard to reproduce as we need a huge size of data to make the cache full.

Expected behavior

The cache garbage collector is not triggered when CACHE_SIZE_UNLIMITED is set and persistenceEnabled is true for iOS.

Sample project

I'm sorry that I cannot provide the sample project.

Flutter doctor

Run flutter doctor and paste the output below:

Click To Expand ``` Doctor summary (to see all details, run flutter doctor -v): [✓] Flutter (Channel stable, 3.7.12, on macOS 14.3.1 23D60 darwin-arm64, locale en-DE) [✓] Android toolchain - develop for Android devices (Android SDK version 34.0.0) [✓] Xcode - develop for iOS and macOS (Xcode 15.2) [✓] Chrome - develop for the web [✓] Android Studio (version 2023.1) [✓] VS Code (version 1.86.1) [✓] Connected device (4 available) [✓] HTTP Host Availability ```

Flutter dependencies

Run flutter pub deps -- --style=compact and paste the output below:

Click To Expand ``` Dart SDK 2.19.6 Flutter SDK 3.7.12 MY_APP x.x.x dependencies: - app_settings 4.3.1 [flutter] - archive 3.3.4 [crypto path pointycastle] - async 2.10.0 [collection meta] - bloc 8.1.2 [meta] - characters 1.2.1 - cloud_firestore 4.9.3 [cloud_firestore_platform_interface cloud_firestore_web collection firebase_core firebase_core_platform_interface flutter meta] - cloud_firestore_platform_interface 5.16.2 [_flutterfire_internals collection firebase_core flutter meta plugin_platform_interface] - collection 1.18.0 - connectivity_plus 2.1.0 [flutter connectivity_plus_platform_interface connectivity_plus_linux connectivity_plus_macos connectivity_plus_web connectivity_plus_windows] - crclib 3.0.0 [meta tuple] - crypto 3.0.2 [typed_data] - cupertino_icons 1.0.5 - device_info_plus 9.0.3 [device_info_plus_platform_interface ffi file flutter flutter_web_plugins meta win32 win32_registry] - dotted_decoration 2.0.0 [flutter] - encrypt 5.0.1 [args asn1lib clock collection crypto pointycastle] - enum_to_string 2.0.1 - equatable 2.0.5 [collection meta] - feedback 2.6.0 [flutter flutter_localizations] - file 6.1.4 [meta path] - firebase_analytics 10.5.1 [firebase_analytics_platform_interface firebase_analytics_web firebase_core firebase_core_platform_interface flutter] - firebase_auth 4.10.1 [firebase_auth_platform_interface firebase_auth_web firebase_core firebase_core_platform_interface flutter meta] - firebase_core 2.17.0 [firebase_core_platform_interface firebase_core_web flutter meta] - firebase_crashlytics 3.3.7 [firebase_core firebase_core_platform_interface firebase_crashlytics_platform_interface flutter stack_trace] - firebase_dynamic_links 5.3.7 [firebase_core firebase_core_platform_interface firebase_dynamic_links_platform_interface flutter meta plugin_platform_interface] - firebase_messaging 14.6.9 [firebase_core firebase_core_platform_interface firebase_messaging_platform_interface firebase_messaging_web flutter meta] - firebase_performance 0.9.2+7 [firebase_core firebase_core_platform_interface firebase_performance_platform_interface firebase_performance_web flutter] - firebase_remote_config 4.2.7 [firebase_core firebase_core_platform_interface firebase_remote_config_platform_interface firebase_remote_config_web flutter] - firebase_storage 11.2.8 [firebase_core firebase_core_platform_interface firebase_storage_platform_interface firebase_storage_web flutter] - flutter 0.0.0 [characters collection js material_color_utilities meta vector_math sky_engine] - flutter_bloc 8.1.3 [bloc flutter provider] - flutter_cache_manager 3.3.0 [clock collection file flutter http path path_provider pedantic rxdart sqflite uuid] - flutter_localizations 0.0.0 [flutter intl characters clock collection js material_color_utilities meta path vector_math] - flutter_pdfview 1.2.5 [flutter] - flutter_secure_storage 8.1.0 [flutter flutter_secure_storage_linux flutter_secure_storage_macos flutter_secure_storage_platform_interface flutter_secure_storage_web flutter_secure_storage_windows meta] - flutter_svg 1.1.6 [flutter meta path_drawing vector_math xml] - freezed_annotation 2.2.0 [collection json_annotation meta] - go_router 6.0.1 [collection flutter flutter_web_plugins logging meta] - google_api_availability 3.0.1 [flutter meta] - http 0.13.6 [async http_parser meta] - image_picker 0.8.6 [flutter image_picker_android image_picker_for_web image_picker_ios image_picker_platform_interface] - intl 0.17.0 [clock path] - json_annotation 4.7.0 [meta] - logger 1.3.0 - lottie 1.3.0 [archive flutter path vector_math] - meta 1.8.0 - model_viewer_plus 1.5.0 [flutter android_intent_plus webview_flutter url_launcher path] - network_image_mock 2.1.1 [flutter mockito] - open_filex 4.3.2 [flutter ffi] - package_info_plus 3.0.2 [ffi flutter flutter_web_plugins http meta path package_info_plus_platform_interface win32] - path_provider 2.0.13 [flutter path_provider_android path_provider_foundation path_provider_linux path_provider_platform_interface path_provider_windows] - pausable_timer 1.0.0+7 [clock] - pdf 3.10.1 [archive barcode bidi crypto image meta path_parsing vector_math xml] - permission_handler 10.2.0 [flutter meta permission_handler_android permission_handler_apple permission_handler_windows permission_handler_platform_interface] - rxdart 0.27.7 - screenshot 1.3.0 [flutter] - scroll_to_index 3.0.1 [flutter] - shake 2.2.0 [sensors_plus flutter] - share_plus 6.3.1 [cross_file meta mime flutter flutter_web_plugins share_plus_platform_interface file url_launcher_web url_launcher_windows url_launcher_linux url_launcher_platform_interface ffi win32] - shared_preferences 2.2.1 [flutter shared_preferences_android shared_preferences_foundation shared_preferences_linux shared_preferences_platform_interface shared_preferences_web shared_preferences_windows] - sound_mode 2.0.2 [flutter] - soundpool 2.3.0 [flutter soundpool_platform_interface soundpool_web soundpool_macos] - url_launcher 6.1.11 [flutter url_launcher_android url_launcher_ios url_launcher_linux url_launcher_macos url_launcher_platform_interface url_launcher_web url_launcher_windows] - uuid 3.0.7 [crypto] - volume_controller 2.0.7 [flutter] - wakelock 0.6.2 [flutter meta wakelock_macos wakelock_platform_interface wakelock_web wakelock_windows] - xml 6.2.2 [collection meta petitparser] dev dependencies: - bloc_test 9.1.3 [bloc diff_match_patch meta mocktail test] - build_runner 2.3.0 [args async analyzer build build_config build_daemon build_resolvers build_runner_core code_builder collection crypto dart_style frontend_server_client glob graphs http_multi_server io js logging meta mime package_config path pool pub_semver pubspec_parse shelf shelf_web_socket stack_trace stream_transform timing watcher web_socket_channel yaml] - fake_cloud_firestore 2.4.1+1 [flutter cloud_firestore cloud_firestore_platform_interface collection plugin_platform_interface quiver rxdart mock_exceptions fake_firebase_security_rules rx] - flutter_launcher_icons 0.10.0 [args checked_yaml cli_util image json_annotation path yaml] - flutter_lints 2.0.1 [lints] - flutter_native_splash 2.2.17 [args flutter flutter_web_plugins js html image meta path universal_io xml yaml] - flutter_test 0.0.0 [flutter test_api path fake_async clock stack_trace vector_math async boolean_selector characters collection js matcher material_color_utilities meta source_span stream_channel string_scanner term_glyph] - freezed 2.2.0 [analyzer build build_config collection meta source_gen freezed_annotation json_annotation] - json_serializable 6.5.4 [analyzer async build build_config collection json_annotation meta path pub_semver pubspec_parse source_gen source_helper] - mocktail 0.3.0 [collection matcher test] dependency overrides: - collection 1.18.0 - image 4.0.17 [archive meta xml] - webview_flutter 2.8.0 [flutter webview_flutter_android webview_flutter_platform_interface webview_flutter_wkwebview] - win32 2.7.0 [ffi] transitive dependencies: - _fe_analyzer_shared 47.0.0 [meta] - _flutterfire_internals 1.3.7 [collection firebase_core firebase_core_platform_interface flutter meta] - analyzer 4.7.0 [_fe_analyzer_shared collection convert crypto glob meta package_config path pub_semver source_span watcher yaml] - android_intent_plus 3.1.9 [flutter platform meta] - ansicolor 2.0.1 - antlr4 4.13.1 [logging collection] - args 2.3.1 - asn1lib 1.4.0 - auto_size_text 3.0.0 [flutter] - barcode 2.2.3 [meta qr] - bidi 2.0.6 - ble_bb50_plugin_flutter 1.4.4 [async collection flutter functional_data intl logging meta protobuf] - boolean_selector 2.1.1 [source_span string_scanner] - build 2.3.1 [analyzer async convert crypto glob logging meta path] - build_config 1.1.1 [checked_yaml json_annotation path pubspec_parse yaml] - build_daemon 3.1.0 [built_collection built_value http_multi_server logging path pool shelf shelf_web_socket stream_transform watcher web_socket_channel] - build_resolvers 2.0.10 [analyzer async build crypto graphs logging path package_config pool pub_semver stream_transform yaml] - build_runner_core 7.2.7 [async build build_config build_resolvers collection convert crypto glob graphs json_annotation logging meta path package_config pool timing watcher yaml] - built_collection 5.1.1 - built_value 8.4.2 [built_collection collection fixnum meta] - cached_network_image 3.2.3 [flutter flutter_cache_manager octo_image cached_network_image_platform_interface cached_network_image_web] - cached_network_image_platform_interface 2.0.0 [flutter flutter_cache_manager] - cached_network_image_web 1.0.2 [flutter flutter_cache_manager cached_network_image_platform_interface] - cel 0.5.3 [antlr4 collection equatable] - checked_yaml 2.0.1 [json_annotation source_span yaml] - chewie 1.3.5 [cupertino_icons flutter provider video_player wakelock] - cli_util 0.3.5 [meta path] - clock 1.1.1 - cloud_firestore_web 3.7.2 [_flutterfire_internals cloud_firestore_platform_interface collection firebase_core firebase_core_web flutter flutter_web_plugins js] - code_builder 4.3.0 [built_collection built_value collection matcher meta] - connectivity_plus_linux 1.3.1 [flutter connectivity_plus_platform_interface meta nm] - connectivity_plus_macos 1.2.6 [connectivity_plus_platform_interface flutter] - connectivity_plus_platform_interface 1.2.3 [flutter meta plugin_platform_interface] - connectivity_plus_web 1.2.5 [connectivity_plus_platform_interface flutter_web_plugins flutter js] - connectivity_plus_windows 1.2.2 [connectivity_plus_platform_interface flutter] - convert 3.1.1 [typed_data] - coverage 1.6.1 [args logging package_config path source_maps stack_trace vm_service] - cross_file 0.3.3+2 [js meta] - csslib 0.17.2 [source_span] - dart_style 2.2.4 [analyzer args path pub_semver source_span] - dbus 0.7.8 [args ffi meta xml] - device_info_plus_platform_interface 7.0.0 [flutter meta plugin_platform_interface] - diff_match_patch 0.4.1 - dio 4.0.6 [http_parser path] - event_bus 2.0.0 - fake_async 1.3.1 [clock collection] - fake_firebase_security_rules 0.5.2 [antlr4 cel equatable logger tuple] - ffi 2.0.1 - firebase_analytics_platform_interface 3.7.1 [_flutterfire_internals firebase_core flutter meta plugin_platform_interface] - firebase_analytics_web 0.5.5+1 [_flutterfire_internals firebase_analytics_platform_interface firebase_core firebase_core_web flutter flutter_web_plugins js] - firebase_auth_platform_interface 6.19.1 [_flutterfire_internals collection firebase_core flutter meta plugin_platform_interface] - firebase_auth_web 5.8.2 [firebase_auth_platform_interface firebase_core firebase_core_web flutter flutter_web_plugins http_parser js meta] - firebase_core_platform_interface 4.8.0 [collection flutter flutter_test meta plugin_platform_interface] - firebase_core_web 2.8.0 [firebase_core_platform_interface flutter flutter_web_plugins js meta] - firebase_crashlytics_platform_interface 3.6.7 [_flutterfire_internals collection firebase_core flutter meta plugin_platform_interface] - firebase_dynamic_links_platform_interface 0.2.6+7 [_flutterfire_internals firebase_core flutter meta plugin_platform_interface] - firebase_messaging_platform_interface 4.5.8 [_flutterfire_internals firebase_core flutter meta plugin_platform_interface] - firebase_messaging_web 3.5.8 [_flutterfire_internals firebase_core firebase_core_web firebase_messaging_platform_interface flutter flutter_web_plugins js meta] - firebase_performance_platform_interface 0.1.4+7 [_flutterfire_internals firebase_core flutter plugin_platform_interface] - firebase_performance_web 0.1.4+7 [_flutterfire_internals firebase_core firebase_core_web firebase_performance_platform_interface flutter flutter_web_plugins js] - firebase_remote_config_platform_interface 1.4.7 [_flutterfire_internals firebase_core flutter meta plugin_platform_interface] - firebase_remote_config_web 1.4.7 [firebase_core firebase_core_web firebase_remote_config_platform_interface flutter flutter_web_plugins js] - firebase_storage_platform_interface 4.4.7 [collection firebase_core flutter meta plugin_platform_interface] - firebase_storage_web 3.6.8 [_flutterfire_internals async firebase_core firebase_core_web firebase_storage_platform_interface flutter flutter_web_plugins http js meta] - fixnum 1.0.1 - fl_chart 0.36.4 [flutter equatable pedantic] - flare_flutter 3.0.2 [collection flutter meta] - flutter_blurhash 0.7.0 [flutter] - flutter_html 3.0.0-beta.2 [html csslib collection list_counter flutter] - flutter_plugin_android_lifecycle 2.0.7 [flutter] - flutter_secure_storage_linux 1.2.0 [flutter flutter_secure_storage_platform_interface] - flutter_secure_storage_macos 3.0.1 [flutter flutter_secure_storage_platform_interface] - flutter_secure_storage_platform_interface 1.0.2 [flutter plugin_platform_interface] - flutter_secure_storage_web 1.1.2 [flutter flutter_secure_storage_platform_interface flutter_web_plugins js] - flutter_secure_storage_windows 2.1.1 [flutter flutter_secure_storage_platform_interface] - flutter_web_plugins 0.0.0 [flutter js characters collection material_color_utilities meta vector_math] - frontend_server_client 2.1.3 [async path] - functional_data 1.1.1 [meta collection] - gap 2.0.1 [flutter] - glob 2.1.1 [async collection file path string_scanner] - google_fonts 4.0.4 [flutter http path_provider crypto] - graphs 2.2.0 [collection] - html 0.15.4 [csslib source_span] - http_multi_server 3.2.1 [async] - http_parser 4.0.2 [collection source_span string_scanner typed_data] - image_picker_android 0.8.5+3 [flutter flutter_plugin_android_lifecycle image_picker_platform_interface] - image_picker_for_web 2.1.10 [flutter flutter_web_plugins image_picker_platform_interface] - image_picker_ios 0.8.6+1 [flutter image_picker_platform_interface] - image_picker_platform_interface 2.6.2 [cross_file flutter http plugin_platform_interface] - io 1.0.3 [meta path string_scanner] - isar 3.1.0 [ffi js meta] - isar_flutter_libs 3.1.0 [flutter isar] - js 0.6.5 [meta] - lint 1.10.0 - lints 2.0.1 - list_counter 1.0.2 - logging 1.1.0 - matcher 0.12.13 [meta stack_trace] - material_color_utilities 0.2.0 - mime 1.0.2 - mock_exceptions 0.8.2 [matcher] - mockito 5.3.2 [analyzer build code_builder collection dart_style matcher meta path source_gen test_api] - more 3.9.5 [characters clock collection meta] - nested 1.0.0 [flutter] - nm 0.5.0 [dbus] - node_preamble 2.0.1 - octo_image 1.0.2 [flutter flutter_blurhash] - open_store 0.4.0 [flutter url_launcher talker] - package_config 2.1.0 [path] - package_info_plus_platform_interface 2.0.1 [flutter meta plugin_platform_interface] - path 1.8.2 - path_drawing 1.0.1 [vector_math meta path_parsing flutter] - path_parsing 1.0.1 [vector_math meta] - path_provider_android 2.0.21 [flutter path_provider_platform_interface] - path_provider_foundation 2.1.2 [flutter path_provider_platform_interface] - path_provider_linux 2.1.7 [ffi flutter path path_provider_platform_interface xdg_directories] - path_provider_platform_interface 2.0.5 [flutter platform plugin_platform_interface] - path_provider_windows 2.1.3 [ffi flutter path path_provider_platform_interface win32] - pedantic 1.11.1 - permission_handler_android 10.2.0 [flutter permission_handler_platform_interface] - permission_handler_apple 9.0.7 [flutter permission_handler_platform_interface] - permission_handler_platform_interface 3.9.0 [flutter meta plugin_platform_interface] - permission_handler_windows 0.1.2 [flutter permission_handler_platform_interface] - petitparser 5.1.0 [meta] - platform 3.1.0 - plugin_platform_interface 2.1.3 [meta] - pointycastle 3.6.2 [collection convert js] - pool 1.5.1 [async stack_trace] - process 4.2.4 [file path platform] - protobuf 3.1.0 [collection fixnum meta] - provider 6.0.4 [collection flutter nested] - pub_semver 2.1.3 [collection meta] - pubspec_parse 1.2.1 [checked_yaml collection json_annotation pub_semver yaml] - qr 3.0.1 [meta] - quiver 3.1.0 [matcher] - rive 0.12.3 [collection flutter flutter_web_plugins http meta plugin_platform_interface rive_common] - rive_common 0.2.8 [collection ffi flutter flutter_web_plugins graphs http meta plugin_platform_interface] - rx 0.1.3 [collection matcher meta more] - sensors_plus 3.1.0 [flutter flutter_web_plugins sensors_plus_platform_interface] - sensors_plus_platform_interface 1.1.3 [flutter meta plugin_platform_interface] - share_plus_platform_interface 3.2.0 [cross_file flutter meta mime plugin_platform_interface path_provider uuid] - shared_preferences_android 2.2.1 [flutter shared_preferences_platform_interface] - shared_preferences_foundation 2.3.4 [flutter shared_preferences_platform_interface] - shared_preferences_linux 2.3.1 [file flutter path path_provider_linux path_provider_platform_interface shared_preferences_platform_interface] - shared_preferences_platform_interface 2.3.1 [flutter plugin_platform_interface] - shared_preferences_web 2.2.1 [flutter flutter_web_plugins shared_preferences_platform_interface] - shared_preferences_windows 2.3.1 [file flutter path path_provider_platform_interface path_provider_windows shared_preferences_platform_interface] - shelf 1.4.0 [async collection http_parser path stack_trace stream_channel] - shelf_packages_handler 3.0.1 [path shelf shelf_static] - shelf_static 1.1.1 [convert http_parser mime path shelf] - shelf_web_socket 1.0.3 [shelf stream_channel web_socket_channel] - sky_engine 0.0.99 - soundpool_macos 2.2.0 [flutter soundpool_platform_interface] - soundpool_platform_interface 2.1.0 [flutter meta plugin_platform_interface] - soundpool_web 2.2.0 [flutter flutter_web_plugins soundpool_platform_interface http] - source_gen 1.2.6 [analyzer async build dart_style glob meta path source_span yaml] - source_helper 1.3.3 [analyzer collection source_gen] - source_map_stack_trace 2.1.1 [path source_maps stack_trace] - source_maps 0.10.11 [source_span] - source_span 1.9.1 [collection path term_glyph] - sqflite 2.2.0+3 [flutter sqflite_common path] - sqflite_common 2.4.0+2 [synchronized path meta] - stack_trace 1.11.0 [path] - stream_channel 2.1.1 [async] - stream_transform 2.1.0 - string_scanner 1.2.0 [source_span] - synchronized 3.0.0+3 - talker 2.1.0 [talker_logger] - talker_logger 2.1.0 [ansicolor] - term_glyph 1.2.1 - test 1.22.0 [analyzer async boolean_selector collection coverage http_multi_server io js node_preamble package_config path pool shelf shelf_packages_handler shelf_static shelf_web_socket source_span stack_trace stream_channel typed_data web_socket_channel webkit_inspection_protocol yaml test_api test_core] - test_api 0.4.16 [async boolean_selector collection meta source_span stack_trace stream_channel string_scanner term_glyph matcher] - test_core 0.4.20 [analyzer async args boolean_selector collection coverage frontend_server_client glob io meta package_config path pool source_map_stack_trace source_maps source_span stack_trace stream_channel vm_service yaml matcher test_api] - timing 1.0.0 [json_annotation] - tuple 2.0.1 - typed_data 1.3.1 [collection] - universal_io 2.0.4 [collection crypto meta typed_data] - url_launcher_android 6.0.21 [flutter url_launcher_platform_interface] - url_launcher_ios 6.0.17 [flutter url_launcher_platform_interface] - url_launcher_linux 3.0.1 [flutter url_launcher_platform_interface] - url_launcher_macos 3.0.1 [flutter url_launcher_platform_interface] - url_launcher_platform_interface 2.1.1 [flutter plugin_platform_interface] - url_launcher_web 2.0.13 [flutter flutter_web_plugins url_launcher_platform_interface] - url_launcher_windows 3.0.1 [flutter url_launcher_platform_interface] - vector_math 2.1.4 - video_player 2.4.7 [flutter html video_player_android video_player_avfoundation video_player_platform_interface video_player_web] - video_player_android 2.3.9 [flutter video_player_platform_interface] - video_player_avfoundation 2.3.7 [flutter video_player_platform_interface] - video_player_platform_interface 5.1.4 [flutter plugin_platform_interface] - video_player_web 2.0.12 [flutter flutter_web_plugins video_player_platform_interface] - vm_service 9.4.0 - wakelock_macos 0.4.0 [flutter flutter_web_plugins wakelock_platform_interface] - wakelock_platform_interface 0.3.0 [flutter meta] - wakelock_web 0.4.0 [flutter flutter_web_plugins js wakelock_platform_interface] - wakelock_windows 0.2.1 [flutter wakelock_platform_interface win32] - watcher 1.0.2 [async path] - web_socket_channel 2.2.0 [async crypto stream_channel] - webfeed 0.7.0 [xml intl] - webkit_inspection_protocol 1.2.0 [logging] - webview_flutter_android 2.10.4 [flutter webview_flutter_platform_interface] - webview_flutter_platform_interface 1.9.5 [flutter meta plugin_platform_interface] - webview_flutter_wkwebview 2.9.5 [flutter path webview_flutter_platform_interface] - win32_registry 1.1.0 [ffi win32] - xdg_directories 0.2.0+2 [meta path process] - yaml 3.1.1 [collection source_span string_scanner] ```
darshankawar commented 9 months ago

Thanks for the report @BradKwon Do you get any logs that might be helpful to properly analyze the issue ? I think in order to properly address the issue, we would need a reproducible code sample that we can use and to make the issue actionable.

BradKwon commented 9 months ago

@darshankawar I find it hard to get any related logs. I will try to find a way to reproduce this issue however, as it is about cache size unlimited, I am not sure yet how I can reproduce it. Maybe I can check if the garbage collector is triggered or not when the cache size is set to unlimited.

Then could you please confirm if the garbage collector is disabled and not triggered, when the cache size is set to unlimited? If so, I think my issue report is wrong.

darshankawar commented 9 months ago

@BradKwon Take a look at native usage of that flag and see if it helps to dig further.

BradKwon commented 9 months ago

@darshankawar I already had a look at it. That's why I am asking the confirmation. I hope this part of my description can help you to confirm if the clean-up is disabled or not.

As far as I understand based on the current implementation of iOS code on the master branch, if cacheSizeBytes is set to CACHE_SIZE_UNLIMITED (= -1), cache setting is set to the max. cache size because it seems there was an issue with kFIRFirestoreCacheSizeUnlimited.

The Firestore doc and https://github.com/firebase/firebase-ios-sdk/discussions/12277#discussioncomment-8152897 say that the cache size should be set to CACHE_SIZE_UNLIMITED (= -1) in order to disable clean-up. However, as it is set to max. cache size in cloud_firestore, I assume that this clean-up will happen when the cache size reaches to the max. size.

darshankawar commented 9 months ago

Thanks for the update. Keeping the issue open and labeling for team's input on the reported behavior.