Replace this paragraph with a list of issues related to this PR from the issue database. Indicate, which of these issues are resolved or fixed by this PR. Note that you'll have to prefix the issue numbers with flutter/flutter#.
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]).
This will ensure a smooth and quick review process. Updating the pubspec.yaml and changelogs is not required.
[ ] I read the Contributor Guide and followed the process outlined there for submitting PRs.
[ ] My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
[ ] All existing and new tests are passing.
[ ] I updated/added relevant documentation (doc comments with ///).
[ ] The analyzer (melos run analyze) does not report any problems on my PR.
Description
GoogleAuthProvider can have nullable idToken and accessToken. See underlying implementation: https://github.com/firebase/firebase-cpp-sdk/blob/e877b22faf5d4b2ad8080179369050ef6c15a2d8/auth/src/desktop/auth_providers/google_auth_provider.cc#L26-L38
I wrote a test to prove you can now pass null values for either
idToken
andaccessToken
but unfortunately the file had to be formatted so it is lost in the diff. Here it is: https://github.com/firebase/flutterfire/pull/12688/files#diff-dd4162c32c7a0146e8a9c7874e8642422e51160833ff49eea64c852b8b215ef9R659-R693I also tested example app with changes to prove Google auth still works on windows:
fixes https://github.com/firebase/flutterfire/issues/12613
Related Issues
Replace this paragraph with a list of issues related to this PR from the issue database. Indicate, which of these issues are resolved or fixed by this PR. Note that you'll have to prefix the issue numbers with flutter/flutter#.
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]
). This will ensure a smooth and quick review process. Updating thepubspec.yaml
and changelogs is not required.///
).melos run analyze
) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?