feat: create new Vertex AI for Firebase plugin.

cynthiajoan commented 2 weeks ago

Description

Add firebase_vertexai plugin. This plugin will provide flutter developer to have access to Vertex AI service. More details in README.md of the package.

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process. Updating the pubspec.yaml and changelogs is not required.

[x] I read the Contributor Guide and followed the process outlined there for submitting PRs.
[x] My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
[x] All existing and new tests are passing.
[x] I updated/added relevant documentation (doc comments with ///).
[x] The analyzer (melos run analyze) does not report any problems on my PR.
[x] I read and followed the Flutter Style Guide.
[x] I signed the CLA.
[x] I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

[ ] Yes, this is a breaking change.
[ ] No, this is not a breaking change.

cynthiajoan commented 1 week ago

Thank you for the PR, @cynthiajoan

A few things to note:

I am aware that the timeline is quite short so I've made some suggestions. I think that this being a dev release gives us more flexibility with future changes, and it might be worth pointing out that the API could change in the future.

For instance, I'm not sure we should have a dependency on App Check as it forces the user to have it + app check plugin initialisation, particularly as we're only interested in the token. There are ways around this issue that would require some internal changes and we can think about that before making it general release.

There are a number of private methods that don't appear to be used but I'm guessing they're for future releases. In any event, they can also be removed in a future release.

I don't think the plugin needs to extend the FirebasePluginPlatform but this will cause issue with the mock tests so it can be left and removed at a later time if we wish.

Thanks Russell. I agree with the app check part, I will point out the sdk is in preview status and apis might be changing.

Lyokone commented 1 week ago

More on the app_check part, we can probably remove the changes made to the example App Check app, so we don't get a weird changelog for app check on the next release. Otherwise I agree with Russell's review 👍

cynthiajoan commented 1 week ago

More on the app_check part, we can probably remove the changes made to the example App Check app, so we don't get a weird changelog for app check on the next release. Otherwise I agree with Russell's review 👍

removed! Thanks for the review

firebase / flutterfire