search

firebase / friendlyeats-web

Apache License 2.0
493 stars 412 forks source link

Set specific version for MDC js and css #41

Closed philrennie closed 6 years ago

philrennie commented 6 years ago

Version 4.0.0 of material-components-web has BC breaks that cause this to stop working. 0.39.0 does work.

Requires reworking how MDCDialog is setup and initialised. MCDDialog.show() is now .open() but just changing the call in FriendlyEats.View.js isn't enough. Believe it needs all the lists shown in the dialog to be updated. I'm not familiar enough with MDC (nor will I be) to do all the updates.

samtstern commented 6 years ago

Hopefully @abehaskins or maybe @nicolasgarnier can look into this. Thanks @philrennie for submitting!

nicolasgarnier commented 6 years ago

Thanks @philrennie

Let's merge this for now since this fixes the codelab for everyone :) We'll look into upgrading to 0.40.0 in a separate PR.