search

firebase / functions-samples

Collection of sample apps showcasing popular use cases using Cloud Functions for Firebase
https://firebase.google.com/docs/functions
Apache License 2.0
12k stars 3.83k forks source link

Add function sample for server-side Remote Config + Vertex AI Gemini API #1135

Closed jenh closed 3 weeks ago

jenh commented 1 month ago

Adds the function and snippets to support https://firebase.google.com/docs/remote-config/solution-server

jenh commented 3 weeks ago

Looks great, just a small nit about the node version -- 18 is approaching end of life so was wondering if it'd make sense to bump it to 20?

I think it would...but it looks like we still reference 18 in the other function samples, and the basic template we create when we init functions with the Firebase CLI is still 18.

Do you think it makes sense to bump the version in separate PRs that update 18 to 20 everywhere (and adds 22 to the CLI, as it's in preview) as a (bigger) separate effort?

HYACCCINT commented 3 weeks ago

Looks great, just a small nit about the node version -- 18 is approaching end of life so was wondering if it'd make sense to bump it to 20?

I think it would...but it looks like we still reference 18 in the other function samples, and the basic template we create when we init functions with the Firebase CLI is still 18.

Do you think it makes sense to bump the version in separate PRs that update 18 to 20 everywhere (and adds 22 to the CLI, as it's in preview) as a (bigger) separate effort?

Oh that's a great point. In that case, absolutely updating in a separate PR would be the best path to go about it, I can look into updating the CLI as well. Thank you so much!!

jenh commented 3 weeks ago

Thank YOU!!! Appreciate the review! :D