firebase / functions-samples

Collection of sample apps showcasing popular use cases using Cloud Functions for Firebase
https://firebase.google.com/docs/functions
Apache License 2.0
12.03k stars 3.83k forks source link

nextjs-with-firebase-hosting sample appears to document a sub-optimal configuration #763

Open banshee opened 4 years ago

banshee commented 4 years ago

This sentence at the beginning of https://github.com/firebase/functions-samples/tree/master/nextjs-with-firebase-hosting is strange:

Host your SSR Next.js app on Cloud Functions with Firebase Hosting rewrite rules. Using a rewrite rule that catches ALL routes we can then host our SSR app on our Firebase Hosting URL instead of the Firebase Cloud Function URL.

This isn't what most people are going to want. You want to serve the static files that are generated by next.js from Firebase Hosting, and non-static files from a cloud function. A rewrite rule that catches all routes doesn't seem like a solution to using Firebase for next.js.

devth commented 3 years ago

+1 / bump