search

firebase / genkit

An open source framework for building AI-powered apps with familiar code-centric patterns. Genkit makes it easy to integrate, test, and deploy sophisticated AI features to Firebase or Google Cloud.
Apache License 2.0
607 stars 74 forks source link

[Tooling] Prompt playground doesn't resolve tools for Dotprompt #197

Closed mbleigh closed 3 months ago

mbleigh commented 3 months ago

Describe the bug When using Dotprompt with tools, the prompt playground doesn't properly resolve them.

To Reproduce Steps to reproduce the behavior:

  1. Define a tool using defineTool
  2. Activate the Dotprompt plugin
  3. Write a .prompt that includes tools: nameOfTool
  4. Open Genkit UI and try to run the prompt

Expected behavior The prompt executes including tool calling.

Actual behavior
The prompt errors with:

Error: INVALID_ARGUMENT: Schema validation failed. Parse Errors:

- tools.0: must be object
MichaelDoyle commented 3 months ago

We're hashing out the tool-call rendering capabilities in the model playground (early this week), and then will integrate into the prompt runner as well. We could push a quick fix to unblock this particular error if needed.

mbleigh commented 3 months ago

No urgency, just reporting the bug.

On Mon, May 20, 2024, 7:43 AM Michael Doyle @.***> wrote:

We're hashing out the tool-call rendering capabilities in the model playground (early this week), and then will integrate into the prompt runner as well. We could push a quick fix to unblock this particular error if needed.

— Reply to this email directly, view it on GitHub https://github.com/firebase/genkit/issues/197#issuecomment-2120605542, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAAH7VZPNOYQQTJNG3IAYDZDIDZJAVCNFSM6AAAAABH6DGJ66VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMRQGYYDKNJUGI . You are receiving this because you authored the thread.Message ID: @.***>

MichaelDoyle commented 3 months ago

Fix is in for the next update.

i2amsam commented 3 months ago

Fixed!