firebase / genkit

An open source framework for building AI-powered apps with familiar code-centric patterns. Genkit makes it easy to integrate, test, and deploy sophisticated AI features to Firebase or Google Cloud.
Apache License 2.0
607 stars 74 forks source link

[JS] [Vertex AI Plugin] [Vector Search] - bigquery retriever is reported as not working #776

Open cabljac opened 1 month ago

cabljac commented 1 month ago

Describe the bug I've opened this issue to track a bug discussed in the discord.

To Reproduce Set up and run the test app at js/testapps/vertexai-vector-search-bigquery

For some users this is not working correctly, it isn't returning results.

Expected behavior A clear and concise description of what you expected to happen.

Screenshots If applicable, add screenshots to help explain your problem.

Runtime (please complete the following information):

** Node version

Additional context Add any other context about the problem here.

ssbushi commented 2 weeks ago

Update: The problem is with the index type -- it must be using the "Stream" update method. Fix is to update the documentation.

cabljac commented 2 weeks ago

https://github.com/firebase/genkit/blob/main/docs/plugins/vertex-ai.md#indexers-and-retrievers

note the docs do mention this already, however i will add to the README of the testapp