firebase / geofire-android

GeoFire for Android apps
Apache License 2.0
133 stars 36 forks source link

Migrate to androidX and bump various libraries #17

Closed warting closed 2 years ago

warting commented 2 years ago

Migrate to androidX and bump various libraries so that jetifier can be turned off Issue: https://github.com/firebase/geofire-android/issues/20

google-cla[bot] commented 2 years ago

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

google-cla[bot] commented 2 years ago

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

warting commented 2 years ago

@googlebot I signed it!

svenjacobs commented 2 years ago

Can this be merged and released, please? Since the newly released Android Studio Chipmunk introduced a Jetifier check in Build Analyzer and flags this library as problematic, this is a more pressing issue now. Thank you very much 😃

thatfiredev commented 2 years ago

@warting @svenjacobs this is now out on v3.2.0 :)

svenjacobs commented 2 years ago

@warting @svenjacobs this is now out on v3.2.0 :)

Thank you! 🙂

warting commented 2 years ago

@warting @svenjacobs this is now out on v3.2.0 :)

Yaaaay, finally time to get rid of the copy paste in my codebase :)