Closed vanniktech closed 6 years ago
Thanks for sending this! Just FYI I'm on vacation this week without a laptop so will review and merge next week when I'm back.
On Mon, Jan 29, 2018, 3:21 AM Niklas Baudy notifications@github.com wrote:
This should conclude #101 https://github.com/firebase/geofire-java/issues/101
You can view, comment on, or merge this pull request online at:
https://github.com/firebase/geofire-java/pull/129 Commit Summary
- Rename methods in GeoFireTestingRule.
File Changes
- M java/src/test/java/com/firebase/geofire/GeoFireIT.java https://github.com/firebase/geofire-java/pull/129/files#diff-0 (14)
- M java/src/test/java/com/firebase/geofire/GeoQueryIT.java https://github.com/firebase/geofire-java/pull/129/files#diff-1 (150)
- M testing/src/main/java/com/firebase/geofire/testing/GeoFireTestingRule.java https://github.com/firebase/geofire-java/pull/129/files#diff-2 (12)
Patch Links:
- https://github.com/firebase/geofire-java/pull/129.patch
- https://github.com/firebase/geofire-java/pull/129.diff
— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/firebase/geofire-java/pull/129, or mute the thread https://github.com/notifications/unsubscribe-auth/AIEw6qYh1CVqSexXGEPr-KGNMgj-mDJEks5tPZurgaJpZM4RwXC4 .
No worries. Enjoy your vacation ;)
@samtstern gentle push
@vanniktech thanks for the reminder, I almost forgot.
This should conclude #101