firebase / geofire-java

GeoFire for Java - Realtime location queries with Firebase
MIT License
670 stars 271 forks source link

Data Events Listener should be changed #138

Closed Choxmi closed 6 years ago

Choxmi commented 6 years ago

Currently in the README.md file contains ,

geoQuery.addGeoQueryEventListener(new GeoQueryDataEventListener() {
```  (Line 293)
which needs to be changed to,
```java
geoQuery.addGeoQueryDataEventListener(new GeoQueryDataEventListener() {
googlebot commented 6 years ago

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers
googlebot commented 6 years ago

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers
Choxmi commented 6 years ago

I signed it!

googlebot commented 6 years ago

CLAs look good, thanks!

samtstern commented 6 years ago

@Choxmi nice catch, thank you!