search

firebase / geofire-java

GeoFire for Java - Realtime location queries with Firebase
MIT License
670 stars 271 forks source link

New way to integrate geofire with existing data #15

Closed dan-dr closed 6 years ago

dan-dr commented 9 years ago

With the late September update of firebase, it's now possible to order by descendants, which from what I see in the code was the reason you couldn't have geo data inside your existing data (couldn't order by the geohash).

It will completely change how GeoFire works so it should probably be 3.0, and i'm guessing the change will have to be on all 3 platforms too.

I'm just putting it out there to see if anyone's working on it.

jwngr commented 9 years ago

I definitely think we can now add this feature to GeoFire! There was some discussion about this here. I don't have time to take this on right now and we need some time think through what this API looks like, but hopefully we will get to this in the near future!

geraldokandonga commented 8 years ago

I am getting aerror noSuchFile on this this.searchCircle = this.map.addCircle(new CircleOptions().center(latLngCenter).radius(1000)); after i changed this code
// setup map and camera position SupportMapFragment mapFragment = (SupportMapFragment)getSupportFragmentManager().findFragmentById(R.id.map); this.map = mapFragment.getMap(); to new google MapAsync

jwngr commented 8 years ago

@gkfillipus - I'm not sure what your code snippet has to do with this particular issue. If you have a usage question, please ask it on Stack Overflow or our Google Group. Please include version info and what exact error you are getting.

vanniktech commented 6 years ago

Is this still something that we want, given that the issue was created more than 2 years ago?

samtstern commented 6 years ago

@vanniktech good point, I think I will close this issue and we can re-focus on smaller things. At this point making so large a change is probably not reasonable, especially given that we'd need to coordinate with the folks on other platforms to make sure the libraries don't conflict.

As you've shown me, it's currently possible to keep Geo data and model data together as long as you're careful about how you update the model data.

vanniktech commented 6 years ago

Yes, we do store the things together, however our API is read-only and we don't write to it.