search

firebase / geofire-js

GeoFire for JavaScript - Realtime location queries with Firebase
MIT License
1.45k stars 345 forks source link

Is Firebase 4.x.x supported? #156

Closed eightyfive closed 6 years ago

eightyfive commented 7 years ago

Version info

Firebase: ^4.1.3

GeoFire: ^4.1.2

Test case

I am using geofire latest with firebase 4.x.x and it seems to work, although the firebase peer dependency listed version is lower: ^2.4.0 || 3.x.x.

So my question is: Is Firebase 4.* officially supported?

Steps to reproduce

  1. Run npm ls
  2. Error in terminal: npm ERR! peer dep missing: firebase@^2.4.0 || 3.x.x, required by geofire@4.1.2

Expected behavior

No warning/error in terminal.

Actual behavior

Warning/error in terminal.

MichaelSolati commented 7 years ago

I've used Geofire with Firebase 4 with no issues what so ever, seriously, I'd say yes it's supported (even though the peer dependency hasn't been updated to reflect that).

jfbourne commented 6 years ago

Same concern here but will give it a shot.

asciimike commented 6 years ago

Thanks for checking, in the future feel free to submit a PR to fix it and we're happy to merge!