firebase / geofire-js

GeoFire for JavaScript - Realtime location queries with Firebase
MIT License
1.44k stars 345 forks source link

refactor: restructure files and abstract typings into namespace #179

Closed MichaelSolati closed 5 years ago

MichaelSolati commented 5 years ago

Description

This is just a clean up of my original work, it still requires a few small tweaks but is neater IMHO

coveralls commented 5 years ago

Coverage Status

Coverage decreased (-4.8%) to 91.346% when pulling 9a5117bcf1f391ebc6c54fd09ba67a0b2a00522f on MichaelSolati:refactor into d5aecb828f29e5fbb6d413d0ddc6d277a4fead01 on firebase:master.

MichaelSolati commented 5 years ago

@mcdonamp I can't find the issue or discussion earlier, but I remember someone having asked if the library will be published onto NPM and then someone said they'd publish it with the NEXT tag while I got the chance to clean up some code. Well the code is cleaned and ready to go. I'd just say that someone will need to update the README.md with new URLs for the CDN, otherwise it's good to go!

asciimike commented 5 years ago

Assigned to @Feiyang1 who is handling our JS releases