Firebase version 9

[jafarijason]

Do you have a plan to support firebase v9 modular? https://firebase.google.com/docs/web/modular-upgrade

I can contribute for using v9

[puf]

It looks like @samtstern started on this at some point: https://github.com/firebase/geofire-js/pull/217.

This would break all backwards compatibility though, so we might need to branch into two releases.

[samtstern]

Breaking backwards compatibility is pretty normal. We do that for FirebaseUI, etc. As long as they're compatible with the latest major SDK version at the time of their release.

Right now geofire is not forwards compatible, to use it you have to use V8 or earlier. That's not good.

[puf]

Shouldn't current GeoFire builds already be able to run on v9's compat layer?

I get that's not ideal. Should your PR already cover all that needs to change?

On Wed, Sep 8, 2021 at 3:19 PM Sam Stern @.***> wrote:

Breaking backwards compatibility is pretty normal. We do that for FirebaseUI, etc. As long as they're compatible with the latest major SDK version at the time of their release.

Right now geofire is not forwards compatible, to use it you have to use V8 or earlier. That's not good.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/firebase/geofire-js/issues/233#issuecomment-915612280, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAG7BXY4DLM623FJ3OWPX6DUA7OPTANCNFSM5DRLOKIQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

[samtstern]

@puf yes they should work well with compat for those using GeoFire via CDN. If you're building into a modern webapp via NPM ... I'm not sure.

I doubt my CL is complete, it was an experiment I did months ago. @jhuleatt can probably advise.

[jafarijason]

It looks like @samtstern started on this at some point: #217.

This would break all backwards compatibility though, so we might need to branch into two releases.

I think if we have something like this for exporting module

export { GeoCallbackRegistration, GeoCallbackRegistrationModular } from './GeoCallbackRegistration';
export { GeoFire, GeoFireModular } from './GeoFire';
export { GeoQuery, GeoQueryModular  } from './GeoQuery';
export * from './GeoFireTypes';

and support both compact and modular will works fine and I saw in #217 @samtstern is try ing only suppor firebase modular but with ^^^ aproach we can supoort both

[zchwyng]

+1

[PanamaDonne]

+1

[isakb]

+1

[spotvin42]

Any news on this?

[tobias74]

I have implemented a quick and dirty upgrade to version 9 "modular".

This is the branch: https://github.com/tobias74/geofire-js/tree/upgrade-to-v9-modular

Sadly I currently do not have the time to make this into a proper pull request.

I just quickly replaced the v8 statements with the v9 counterparts. Along the way I had to remove some of the types and use "any". I believe the settings in my tsconfig are not compatible, the compiler kept complaining constantly.

Also I did not have the time to use proper typings for the parts that I introduced. (I know, there is no excuse for that) but I had to rush things just to get it working in my own (non-typescript) project.

Again, appologies for this half-baked attempt. Maybe someone can help me finish it?

(I did not even run the tests, I just used it directly in my project and everything seemed to be ok)

[evdama]

Hi folks... what's the current status on supporting fb v9?

[AliMohammad93]

is there any solution for that ?

[anckaertv]

Any news on this ? Thanks in advance

[rashearth]

Hi, first, thanks for the good app! I would also like to use the version9, looking forward!!

[thatfiredev]

Hey all! We have just released geofire version 6.0.0 which now supports the v9 sdk :) Thanks patiently waiting on this! 🙏

[isakb]

Awesome! Thank you so much!

On Wed, Jul 13, 2022, 21:20 Rosário Pereira Fernandes < @.***> wrote:

Hey all! We have just released geofire version 6.0.0 https://github.com/firebase/geofire-js/releases/tag/6.0.0 which now supports the v9 sdk :) Thanks patiently waiting on this! 🙏

— Reply to this email directly, view it on GitHub https://github.com/firebase/geofire-js/issues/233#issuecomment-1183589437, or unsubscribe https://github.com/notifications/unsubscribe-auth/AADCY4MMS7Y5A2IBLM7YXMLVT4JHXANCNFSM5DRLOKIQ . You are receiving this because you commented.Message ID: @.***>

[PanamaDonne]

🎉🎉🎉 great!

Den ons 13 juli 2022 21:14Isak Bakken @.***> skrev:

Awesome! Thank you so much!

On Wed, Jul 13, 2022, 21:20 Rosário Pereira Fernandes < @.***> wrote:

Hey all! We have just released geofire version 6.0.0 https://github.com/firebase/geofire-js/releases/tag/6.0.0 which now supports the v9 sdk :) Thanks patiently waiting on this! 🙏

— Reply to this email directly, view it on GitHub < https://github.com/firebase/geofire-js/issues/233#issuecomment-1183589437 , or unsubscribe < https://github.com/notifications/unsubscribe-auth/AADCY4MMS7Y5A2IBLM7YXMLVT4JHXANCNFSM5DRLOKIQ

. You are receiving this because you commented.Message ID: @.***>

— Reply to this email directly, view it on GitHub https://github.com/firebase/geofire-js/issues/233#issuecomment-1183803089, or unsubscribe https://github.com/notifications/unsubscribe-auth/AATQA43BGA4656AHPR46PULVT5LX7ANCNFSM5DRLOKIQ . You are receiving this because you commented.Message ID: @.***>