search

firebase / geofire-js

GeoFire for JavaScript - Realtime location queries with Firebase
MIT License
1.45k stars 345 forks source link

If GeoFire is being run in node, firebase is not included #27

Closed markdegrootnl closed 10 years ago

markdegrootnl commented 10 years ago

If GeoFire is being run in node, firebase is not included. This:

  var Firebase = require("firebase");

should be added to the following:

// Include RSVP if this is being run in node
if (typeof module !== "undefined" && typeof process !== "undefined") {
  var RSVP = require("rsvp");
}
jwngr commented 10 years ago

Thanks for pointing this out! I'll make sure to get this fixed in the next release.

jwngr commented 10 years ago

This is now fixed. FYI: it may be a little bit until we release a new version of the client though.

jwngr commented 10 years ago

This is now live with version 3.0.0 which was just released.