firebase / geofire-objc

GeoFire for Objective-C - Realtime location queries with Firebase
MIT License
436 stars 180 forks source link

Add nullability annotations to public API #106

Closed nolanw closed 6 years ago

nolanw commented 6 years ago

As mentioned in #105.

Nullability annotations were introduced in Xcode 6.3 (which included iOS 8.3). I'm not sure what the minimum supported Xcode version is in these parts, but if 6.3 is a reasonable minimum then we shouldn't need any #define NS_ASSUME_NONNULL_BEGIN etc. to pacify older versions of the dev tools. Let me know if I've guessed wrong here.

googlebot commented 6 years ago

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


googlebot commented 6 years ago

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


nolanw commented 6 years ago

I signed it!

googlebot commented 6 years ago

CLAs look good, thanks!

morganchen12 commented 6 years ago

@mcdonamp please merge when you get a moment

asciimike commented 6 years ago

@nolanw, @morganchen12 Sorry about the delay. One minor change on the public surface; otherwise, LGTM. Thanks for doing this!

nolanw commented 6 years ago

Not nullable it is!

asciimike commented 6 years ago

LGTM

asciimike commented 6 years ago

@morganchen12, do you have permissions to release, or do you need me to?

morganchen12 commented 6 years ago

I don't have release permissions, so please make a new release when you have the time.

Thanks!

asciimike commented 6 years ago

Published in v2.0.1.