Closed nolanw closed 6 years ago
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).
:memo: Please visit https://cla.developers.google.com/ to sign.
Once you've signed, please reply here (e.g. I signed it!
) and we'll verify. Thanks.
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).
:memo: Please visit https://cla.developers.google.com/ to sign.
Once you've signed, please reply here (e.g. I signed it!
) and we'll verify. Thanks.
I signed it!
CLAs look good, thanks!
@mcdonamp please merge when you get a moment
@nolanw, @morganchen12 Sorry about the delay. One minor change on the public surface; otherwise, LGTM. Thanks for doing this!
Not nullable it is!
LGTM
@morganchen12, do you have permissions to release, or do you need me to?
I don't have release permissions, so please make a new release when you have the time.
Thanks!
Published in v2.0.1.
As mentioned in #105.
Nullability annotations were introduced in Xcode 6.3 (which included iOS 8.3). I'm not sure what the minimum supported Xcode version is in these parts, but if 6.3 is a reasonable minimum then we shouldn't need any
#define NS_ASSUME_NONNULL_BEGIN
etc. to pacify older versions of the dev tools. Let me know if I've guessed wrong here.