Closed RaMin0 closed 6 years ago
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).
:memo: Please visit https://cla.developers.google.com/ to sign.
Once you've signed (or fixed any issues), please reply here (e.g. I signed it!
) and we'll verify it.
go/cla#troubleshoot
.Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).
:memo: Please visit https://cla.developers.google.com/ to sign.
Once you've signed (or fixed any issues), please reply here (e.g. I signed it!
) and we'll verify it.
go/cla#troubleshoot
.I signed it!
CLAs look good, thanks!
@mcdonamp please review
@RaMin0 @morganchen12 it looks like we don't actually need priority (we store the geohash in g
and query by that, rather than priority), so I'd just remove the code and tests for priority and use update, no need to do the second update.
Presumably this is so you can store additional data alongside the GeoFire info?
@mcdonamp: Presumably this is so you can store additional data alongside the GeoFire info
Yes, it made more sense to save the related info stored in the same node rather than having a parallel node that I have to maintain just to keep the extra info.
One other thing I suggest to do is to make the name of the location key (currently l
) configurable, to give more context. pickUpLocation
is more significant than just l
. But that's an issue for another PR.
@mcdonamp Check 96f40431d0d0fe3aac66bc0302da6c9cf3ab2f58.
Use
updateChildValues
(andsetPriority
) in favor ofsetValuesAndPriority
to avoid overwriting other child values.