firebase / geofire-objc

GeoFire for Objective-C - Realtime location queries with Firebase
MIT License
436 stars 180 forks source link

2 compiler warnings (Documentation issue) in Xcode 9 / Swift 4 project #98

Closed ghost closed 5 years ago

ghost commented 7 years ago

Pods/GeoFire/GeoFire/API/GeoFire.h:108:11: Empty paragraph passed to '@return' command

Pods/GeoFire/GeoFire/API/GeoFire.h:108:5: '@return' command used in a comment that is attached to a method returning void

moazkh60 commented 7 years ago

I am facing the same issue. Geofire team Please resolve this issue at the earliest.

ghost commented 7 years ago

Got one more (semantic issue):

Pods/GeoFire/GeoFire/API/GFQuery.h:43:30: This block declaration is not a prototype

brokenseal commented 7 years ago

Is this project actually maintained? No reply in more than a month to a fairly pressing issue, that is a bad sign...

SaifSideDev commented 6 years ago

@mcdonamp Hey, GeoFire seems great. Any ETA on when GeoFire pods will be ready to use with Swift 4 and Firebase 4 Xcode projects?

brokenseal commented 6 years ago

@SaifSideDev I am using it with a Swift 4 project

SaifSideDev commented 6 years ago

@brokenseal That's awesome. I figured it out too. Are you using the Firebase Community pods? That's how I got it to work for anyone who is wondering.

doovers commented 6 years ago

@SaifSideDev I used this workaround with the normal Firebase pods and it works fine too:

# GeoFire workaround
post_install do |installer|
    installer.pods_project.targets.each do |target|
        if target.name == 'GeoFire' then
            target.build_configurations.each do |config|
                config.build_settings['FRAMEWORK_SEARCH_PATHS'] = "#{config.build_settings['FRAMEWORK_SEARCH_PATHS']} ${PODS_ROOT}/FirebaseDatabase/Frameworks/ $PODS_CONFIGURATION_BUILD_DIR/GoogleToolboxForMac $PODS_CONFIGURATION_BUILD_DIR/nanopb $PODS_CONFIGURATION_BUILD_DIR/leveldb-library"
                config.build_settings['OTHER_LDFLAGS'] = "#{config.build_settings['OTHER_LDFLAGS']} -framework FirebaseDatabase"
            end
        end
    end
end
morganchen12 commented 5 years ago

These should be fixed in master; please re-open if they aren't.