search

firebase / php-jwt

PHP package for JWT
BSD 3-Clause "New" or "Revised" License
9.38k stars 1.27k forks source link

Improve IDE autocompletion #500

Closed shenkimaro closed 1 year ago

shenkimaro commented 1 year ago

A typed or constant Class added. This class has all available algorithms. In general, this type of class improves the autocomplete action in IDEs that only search for the class and already show the possibilities, avoiding text typing errors.

google-cla[bot] commented 1 year ago

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

bshaffer commented 1 year ago

Thank you for your contribution! This looks great. Consider updating the $supported_algs property in the JWT class as well! And also you'll need to sign the CLA for us to merge this.

Note: This can become an Enum class once support for PHP 8.0 and below is dropped