firebase / php-jwt

PHP package for JWT
BSD 3-Clause "New" or "Revised" License
9.3k stars 1.26k forks source link

fix: update error text for consistency #528

Open fredden opened 12 months ago

fredden commented 12 months ago

This is a follow-up to https://github.com/firebase/php-jwt/pull/492 where an inconsistency was introduced. When triggering these error messages, if the value should be rounded up, then the value in the error message won't match the value being checked. Given we're talking about fractions of a second, this shouldn't cause any real-world impact. This inconsistency may make debugging edge cases difficult, leading to confusion. This confusion may lead do setting too much leeway in timing settings.