search

firebase / php-jwt

PHP package for JWT
BSD 3-Clause "New" or "Revised" License
9.3k stars 1.26k forks source link

fix: readme or documentation about decoding jwt #569

Open SySafarila opened 3 weeks ago

SySafarila commented 3 weeks ago

fixing typo on Readme about JWT Decode parameter from $payload to $jwt.

before fixed: 

JWT::decode($payload, $key);

after fixed: 

JWT::decode($jwt, $key);
google-cla[bot] commented 3 weeks ago

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

SySafarila commented 3 weeks ago

Hello, my name is Syahrul Safarila. I just reading the Readme and find out that some documentation about decoding JWT are need variable called $payload instead of $jwt.

i hope this pull request can help other developers to understand required parameter for decoding JWT.

bshaffer commented 14 hours ago

Hi @SySafarila ! Thanks for your contribution, this looks great!

Before we can merge it, you will need to sign our Contributor License Agreement (CLA). All contributors must be covered under a CLA for them to contribute to our open source repositories.

Please visit https://cla.developers.google.com/. Once you've signed, follow the "New Contributors" link at the bottom of that page to update this check.

Thanks again!

SySafarila commented 11 hours ago

hi @bshaffer !, I have registered on the CLA already, and its look like just need a reviewer for this pull request to get merge