firebase / quickstart-cpp

Firebase Quickstart Samples for C++
https://firebase.google.com/games
Apache License 2.0
212 stars 123 forks source link

Create functions project #31

Closed jpoag closed 6 years ago

jpoag commented 6 years ago

Demo project for using Cloud Functions from App. Includes an echo server.

This pull request is primarily to reproduce an issue with Cloud Functions. However, with a little cleanup, this would be very useful in it's own right.

bklimt commented 6 years ago

Hi @jpoag, thanks for taking the time to make this. I see it has some conflicts with the existing sample app that would need to be resolved. I'm guessing when you started creating this sample app, the other one didn't exist yet? Then is this pull request obsolete?

jpoag commented 6 years ago

The other example did not exist or wasn't in the master branch when I wrote this. This currently serves as the reproduction example for #32 , so as soon as that is closed (which should be soon-ish) we can reject the pull request and I'll close out my fork.

jpoag commented 6 years ago

No longer needed. Issue #32 has been fixed in C++ SDK release 5.3.0 https://firebase.google.com/support/release-notes/cpp-relnotes