firebase / quickstart-cpp

Firebase Quickstart Samples for C++
https://firebase.google.com/games
Apache License 2.0
206 stars 122 forks source link

Project is some update needs. (gradle.properties, AndroidMnifest.xml, google-services.json) #82

Closed masteage closed 3 years ago

masteage commented 3 years ago

Please fill in the following fields:

Please describe the issue here:

Please answer the following, if applicable:

chkuang-g commented 3 years ago

Hi @masteage

Thank you for the suggestions.

I think the AndroidX/Jetifier change in gradle.properties make sense. However, all of the others are documented in readme.

I think you still need to follow instructions from readme for the sample Admob App Id and mock google-services.json anyway. Is there a particular reason you think those change are necessary?

Shawn

chkuang-g commented 3 years ago

BTW, currently we do not accept pull request in this repo.