search

firebase / quickstart-java

Quickstart samples for Firebase Java Admin SDK
Apache License 2.0
234 stars 143 forks source link

Revoke tokens and verify check revoked snippets #21

Closed avishalom closed 6 years ago

samtstern commented 6 years ago

@avishalom Travis is saying that things don't compile. Are these snippets for unreleased code?

avishalom commented 6 years ago

Yes, it is unreleased. I'm not sure how to set up the build to pull the newer branch, as it is it is pulling version 5.6.0 (which is 2 behind)

samtstern commented 6 years ago

@avishalom yeah there's not much we can do since the Java Admin SDK does not publish snapshot builds anywhere. We'll just have to hold this PR unmerged until the SDK is released and we can update your branch to the public version (I guess 5.9.0 ?)

avishalom commented 6 years ago

Ok, we can do it in steps. do you know how https://github.com/firebase/snippets-java/pull/2 is green? it contains FCM code that doesn't exist in 5.8.0 ?

samtstern commented 6 years ago

@avishalom that pull request was sent before I enabled Travis on the repository (I only added Travis this week) so I guess it never built at all.