search

firebase / snippets-android

Android snippets for firebase.google.com
Apache License 2.0
763 stars 398 forks source link

startActivityForResult depricated #316

Open shrirampanchal opened 2 years ago

shrirampanchal commented 2 years ago

Since startActivityForResult depricated how to target GoogleSignIn for new android versions

MatthewFallon commented 2 years ago

May get around to this later, but wanted to post the relevant links that show up for fixing this and the areas I found the problem in.

https://github.com/firebase/snippets-android/blob/7268f816496dac6990b9587874520daeeba46333/auth/app/src/main/java/com/google/firebase/quickstart/auth/GoogleSignInActivity.java#L128 https://github.com/firebase/snippets-android/blob/7268f816496dac6990b9587874520daeeba46333/auth/app/src/main/java/com/google/firebase/quickstart/auth/kotlin/GoogleSignInActivity.kt#L100

Links: https://developer.android.com/training/basics/intents/result https://stackoverflow.com/questions/62671106/onactivityresult-method-is-deprecated-what-is-the-alternative

thatfiredev commented 2 years ago

@MatthewFallon Let me know if you still wish to contribute :)

yveskalume commented 12 months ago

Hey @thatfiredev is it to late to contribute ?

thatfiredev commented 12 months ago

@yveskalume I'm looking at our docs for Google Sign-in, and it seems like they have been updated for One Tap Sign-in and we no longer use startActivityForResult, so this should no longer be an issue. 🥲