search

firebase / snippets-node

Node.js snippets for firebase.google.com
Apache License 2.0
372 stars 132 forks source link

chore: Edited the query filter to remove .get() #377

Closed shweta345 closed 11 months ago

shweta345 commented 11 months ago

Updated the code to resolve a customer feedback about understanding simple queries due to the .get() function.

thatfiredev commented 11 months ago

Hey @shweta345 Can you please describe what issue the customer was running into? Links to public Github issues or internal bug tickets are welcome. Thanks!

shweta345 commented 11 months ago

@thatfiredev Internal bug ID that it targets is http://b/300413440. I was unsure if I should link it here :)

thatfiredev commented 11 months ago

@shweta345 I do see the 2 simple queries that the customer seems to be talking about:

Screenshot 2023-11-28 at 11 22 29

But they don't seem to match with the query you're updating in this PR:

https://github.com/shweta345/snippets-node/blob/c234a3db471da94e5c9be8a29d856e4a8df9e31e/firestore/main/index.js#L590

shweta345 commented 11 months ago

@thatfiredev This is the link that customer has shared: https://cloud.google.com/firestore/docs/query-data/queries#simple_queries. If you see the second snippet, it is the one that I edited. (Node.js language)

shweta345 commented 11 months ago

@thatfiredev Merged your edits. Thank you! :)