firebase / snippets-web

Web snippets for firebase.google.com
Apache License 2.0
752 stars 241 forks source link

missing keyword `await` for the set_with_merge.js file #330

Open waldothedeveloper opened 1 year ago

waldothedeveloper commented 1 year ago

The docs related to Set a document see here are missing the keyword await before setDoc() function. For the code example where the { merge: true} is used.

image

All of the previous and subsequent code snippets do contain the word await for the setDoc() function. Does the {merge: true} change the async behavior of the setDoc() function?

If not, the await should be present in that snippet to match all of the other code snippets for this page.

Here's another example on the same page where the await keyword is present for the setDoc() function:

image

waldothedeveloper commented 1 year ago

I can submit a PR if needed :)