search

firebase / snippets-web

Web snippets for firebase.google.com
Apache License 2.0
752 stars 241 forks source link

import module name incorrect for firebase/database #338

Closed kmc00 closed 1 year ago

kmc00 commented 1 year ago

https://github.com/firebase/snippets-web/blob/e2beb93c2842b540ce78403ff4e2b115ebc0d072/snippets/database-next/index/rtdb_get_reference.js

All import refrances to Firebase Database are incorrect. Should be @firebase/database and not firebase/database

thatfiredev commented 1 year ago

@CoombesJ based on this SO answer, it looks like the use of @ depends on what module loader/bundler you're using.

I believe most module loaders don't need @, so I would vote to keep the snippet as it is.

thatfiredev commented 1 year ago

Closing this for now. Feel free to reopen if you still need help