search

firebase / snippets-web

Web snippets for firebase.google.com
Apache License 2.0
737 stars 241 forks source link

Update app check imports #340

Closed dwyfrequency closed 1 year ago

dwyfrequency commented 1 year ago

User encountered import error follow the docs here https://firebase.google.com/docs/app-check/web/recaptcha-provider#initialize. Although the docs are not incorrect, we would like to update the example to use esm modules https://github.com/firebase/firebase-js-sdk/issues/7288#issuecomment-1544475416 Issue: https://github.com/firebase/firebase-js-sdk/issues/7288

thatfiredev commented 1 year ago

@dwyfrequency Thanks for finding this. Looks like the snippet with the correct import already exists:

https://github.com/firebase/snippets-web/blob/e2beb93c2842b540ce78403ff4e2b115ebc0d072/snippets/appcheck-next/index/appcheck_initialize.js#L7-L24

The problem is we linked the wrong snippet in firesite. I have opened cl/532053153 to fix this.