search

firebase / snippets-web

Web snippets for firebase.google.com
Apache License 2.0
752 stars 241 forks source link

missing keyword await fixed issue #330 #345

Closed priyanshuverma-dev closed 9 months ago

priyanshuverma-dev commented 1 year ago

fixed issue #330 The docs related to Set a document see here are missing the keyword await before setDoc() function. For the code example where the { merge: true} is used.

google-cla[bot] commented 1 year ago

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

thatfiredev commented 9 months ago

@priyanshuverma-dev it seems like you may have committed with multiple emails which have not signed the CLA, and that's what's causing the CLA check to fail. Can you take a look?

An easier alternative would be to open a new PR and only commit with the email that has signed the CLA.