firebase / snippets-web

Web snippets for firebase.google.com
Apache License 2.0
737 stars 241 forks source link

Add missing provider definition #353

Closed sourabh32 closed 1 year ago

sourabh32 commented 1 year ago

added missing provider definition

thatfiredev commented 1 year ago

@sourabh32 In our docs, the provider definition is actually done in step 1: https://firebase.google.com/docs/auth/web/google-signin#handle_the_sign-in_flow_with_the_firebase_sdk

The snippet you just edited is for step 5 - we assume readers have already done step 1 by the time they get there, which means the provider has already beed defined.

thatfiredev commented 1 year ago

Closing this for now. But let me know if you disagree with my previous comment