search

firebase / superstatic

Superstatic: a static file server for fancy apps.
MIT License
1.1k stars 81 forks source link

simplify compression configuration #404

Closed frankli0324 closed 1 year ago

frankli0324 commented 1 year ago

allow configuring compression with cli options or configuration file compression is a feature that is quite commonly used, I believe

bkendall commented 1 year ago

What kinds of compression options are you interested in? compression is a config that we do include (to gzip content) - I'd have to check/verify that it's in the CLI's flags. But is there something you have in mind?

frankli0324 commented 1 year ago

I mean exactly the compression option. hoping for it to be included in cli flags 🙏

bkendall commented 1 year ago

Truth be told, it's probably not something I can get to and implement in a reasonable timeframe (the CLI flags aren't the usual way we usually use this module) but a PR would always be welcome!

frankli0324 commented 1 year ago

Will do this weekend:) just realized that this issue is numbered 404

frankli0324 commented 1 year ago

sorry but it turns out that superstatic does support --compression, but not mentioned in README.